From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH v2 2/2] doc/SubmittingPatches: show how to get a CLI commit summary
Date: Tue, 21 Mar 2017 16:51:53 +0100 [thread overview]
Message-ID: <20170321155153.20753-1-szeder.dev@gmail.com> (raw)
In-Reply-To: <20170321142154.16993-3-avarab@gmail.com>
> Amend the section which describes how to get a commit summary to show
> how do to that with "git show", currently the documentation only shows
> how to do that with gitk.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
> Documentation/SubmittingPatches | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index 9ef624ce38..d8c88153c1 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -134,8 +134,17 @@ with the subject enclosed in a pair of double-quotes, like this:
> noticed that ...
>
> The "Copy commit summary" command of gitk can be used to obtain this
> -format.
> +format, or this invocation of "git show":
>
> + git show -s --date=short --pretty='format:%h ("%s", %ad)' <commit>
> +
> +To turn that into a handy alias:
> +
> + git config --global alias.git-commit-summary "show -s --date=short --pretty='format:%h (\"%s\", %ad)'"
> +
> +And then to get the commit summary:
> +
> + git git-commit-summary <commit>
- 'tformat:' is a better fit than 'format:' in this case, because it
adds a trailing newline.
- I actually have a pretty format alias exactly for this purpose:
pretty.commitref=tformat:%h (%s, %as)
and a shorter 'git log -1 --pretty=commitref <commit>' does the
trick. Perhaps it would be worth to provide this as a builtin
pretty format.
(Of course this relies on '%as' being interpreted as short author
date to make the format work on its own, without the additional
'--date=short'. Alas, git doesn't support this, see [1].
If only there were a pretty format specifier for suppressing diff
output, then the '-s' could go away as well.)
- I find that the two subsequent 'git's in 'git git-<whatever>' look
strange. However, to make this point moot right away:
- I don't think SubmittingPatches is the right place to show how to
create and use a command alias.
[1] - http://public-inbox.org/git/1444235305-8718-1-git-send-email-szeder@ira.uka.de/T/#u
next prev parent reply other threads:[~2017-03-21 15:52 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-18 10:32 [PATCH 0/8] Various changes to the "tag" command Ævar Arnfjörð Bjarmason
2017-03-18 10:32 ` [PATCH 1/8] tag: Remove a TODO item from the test suite Ævar Arnfjörð Bjarmason
2017-03-18 18:14 ` Junio C Hamano
2017-03-18 18:42 ` [PATCH 0/2] doc/SubmittingPatches: A couple of minor improvements Ævar Arnfjörð Bjarmason
2017-03-18 18:42 ` [PATCH 1/2] doc/SubmittingPatches: clarify the casing convention for "area: change..." Ævar Arnfjörð Bjarmason
2017-03-18 19:04 ` Junio C Hamano
2017-03-18 19:16 ` Ævar Arnfjörð Bjarmason
2017-03-18 20:07 ` Junio C Hamano
2017-03-18 18:42 ` [PATCH 2/2] doc/SubmittingPatches: show how to get a CLI commit summary Ævar Arnfjörð Bjarmason
2017-03-18 19:07 ` Junio C Hamano
2017-03-21 14:21 ` [PATCH v2 0/2] A couple of minor improvements Ævar Arnfjörð Bjarmason
2017-03-21 14:21 ` [PATCH v2 1/2] doc/SubmittingPatches: clarify the casing convention for "area: change..." Ævar Arnfjörð Bjarmason
2017-03-21 14:21 ` [PATCH v2 2/2] doc/SubmittingPatches: show how to get a CLI commit summary Ævar Arnfjörð Bjarmason
2017-03-21 15:51 ` SZEDER Gábor [this message]
2017-03-21 17:58 ` Junio C Hamano
2017-03-21 18:47 ` Ævar Arnfjörð Bjarmason
2017-03-21 20:01 ` SZEDER Gábor
2017-03-21 20:13 ` Junio C Hamano
2017-03-19 0:48 ` [PATCH 1/8] tag: Remove a TODO item from the test suite Jakub Narębski
2017-03-19 6:43 ` Ævar Arnfjörð Bjarmason
2017-03-18 10:32 ` [PATCH 2/8] tag: Refactor the options handling code to be less bizarro Ævar Arnfjörð Bjarmason
2017-03-18 18:35 ` Junio C Hamano
2017-03-18 19:13 ` Ævar Arnfjörð Bjarmason
2017-03-18 19:27 ` Junio C Hamano
2017-03-18 20:00 ` Ævar Arnfjörð Bjarmason
2017-03-18 10:32 ` [PATCH 3/8] tag: Change misleading --list <pattern> documentation Ævar Arnfjörð Bjarmason
2017-03-18 18:43 ` Junio C Hamano
2017-03-18 19:49 ` Ævar Arnfjörð Bjarmason
2017-03-20 3:44 ` Jeff King
2017-03-20 15:55 ` Junio C Hamano
2017-03-20 17:07 ` Junio C Hamano
2017-03-20 16:09 ` Ævar Arnfjörð Bjarmason
2017-03-20 16:11 ` Jeff King
2017-03-18 10:32 ` [PATCH 4/8] tag: Implicitly supply --list given another list-like option Ævar Arnfjörð Bjarmason
2017-03-20 3:55 ` Jeff King
2017-03-20 9:16 ` Ævar Arnfjörð Bjarmason
2017-03-18 10:32 ` [PATCH 5/8] tag: Implicitly supply --list given the -n option Ævar Arnfjörð Bjarmason
2017-03-20 4:02 ` Jeff King
2017-03-18 10:32 ` [PATCH 6/8] ref-filter: Add --no-contains option to tag/branch/for-each-ref Ævar Arnfjörð Bjarmason
2017-03-20 4:25 ` Jeff King
2017-03-20 9:32 ` Ævar Arnfjörð Bjarmason
2017-03-20 19:52 ` Jeff King
2017-03-20 20:04 ` Ævar Arnfjörð Bjarmason
2017-03-18 10:32 ` [PATCH 7/8] tag: Add tests for --with and --without Ævar Arnfjörð Bjarmason
2017-03-18 10:32 ` [PATCH 8/8] tag: Change --point-at to default to HEAD Ævar Arnfjörð Bjarmason
2017-03-18 18:54 ` Junio C Hamano
2017-03-18 19:52 ` Ævar Arnfjörð Bjarmason
2017-03-20 4:26 ` [PATCH 0/8] Various changes to the "tag" command Jeff King
2017-03-20 15:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321155153.20753-1-szeder.dev@gmail.com \
--to=szeder.dev@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).