From: Brandon Williams <bmwill@google.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] sequencer: fix missing newline
Date: Thu, 23 Mar 2017 11:24:24 -0700 [thread overview]
Message-ID: <20170323182424.GB111250@google.com> (raw)
In-Reply-To: <20170323182221.i3noikxpmrn4ymi4@sigill.intra.peff.net>
On 03/23, Jeff King wrote:
> On Thu, Mar 23, 2017 at 10:47:16AM -0700, Brandon Williams wrote:
>
> > On 03/23, Johannes Schindelin wrote:
> > > Hi Brandon,
> > >
> > > On Thu, 23 Mar 2017, Brandon Williams wrote:
> > >
> > > > When using rebase --interactive where one of the lines is marked as
> > > > 'edit' this is the resulting output:
> > > >
> > > > Stopped at ec3b9c4... stuffYou can amend the commit now, with
> > >
> > > Ugh, I should have caught this. The warning() call implicitly adds a
> > > newline, the fprintf() doesn't.
> > >
> > > Patch is obviously good.
> >
> > All good. If we're keeping score for finding each others bugs, I still
> > think you're winning :)
>
> It's my bug, actually. Brown paper bag, anyone?
TIL I should use 'blame' before actually blaming someone ;P
--
Brandon Williams
next prev parent reply other threads:[~2017-03-23 18:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 17:02 [PATCH] sequencer: fix missing newline Brandon Williams
2017-03-23 17:40 ` Johannes Schindelin
2017-03-23 17:47 ` Brandon Williams
2017-03-23 18:22 ` Jeff King
2017-03-23 18:24 ` Jeff King
2017-03-23 18:24 ` Brandon Williams [this message]
2017-03-23 18:19 ` Junio C Hamano
2017-03-23 22:12 ` Jonathan Nieder
2017-03-23 22:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323182424.GB111250@google.com \
--to=bmwill@google.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).