From: Kevin Willford <kcwillford@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, peff@peff.net, Kevin Willford <kewillf@microsoft.com>
Subject: [PATCH 1/3] merge-recursive.c: conflict using sparse should update file
Date: Fri, 7 Apr 2017 12:23:55 -0700 [thread overview]
Message-ID: <20170407192357.948-2-kewillf@microsoft.com> (raw)
In-Reply-To: <20170407192357.948-1-kewillf@microsoft.com>
Update the file when there is a conflict with a modify/delete scenario
when using the sparse-checkout feature since the file might not be on disk
because the skip-worktree bit is on and the user will need the file and
content to determine how to resolve the conflict.
Signed-off-by: Kevin Willford <kewillf@microsoft.com>
---
merge-recursive.c | 8 ++++++++
t/t7614-merge-sparse-checkout.sh | 27 +++++++++++++++++++++++++++
2 files changed, 35 insertions(+)
create mode 100755 t/t7614-merge-sparse-checkout.sh
diff --git a/merge-recursive.c b/merge-recursive.c
index b7ff1ada3c..54fce93dae 100644
--- a/merge-recursive.c
+++ b/merge-recursive.c
@@ -1103,6 +1103,14 @@ static int handle_change_delete(struct merge_options *o,
"and %s in %s. Version %s of %s left in tree."),
change, path, o->branch2, change_past,
o->branch1, o->branch1, path);
+ /*
+ * In a sparse checkout the file may not exist. Sadly,
+ * the CE_SKIP_WORKTREE flag is not preserved in the
+ * case of conflicts, therefore we do the next best
+ * thing: verify that the file exists.
+ */
+ if (!file_exists(path))
+ ret = update_file(o, 0, a_oid, a_mode, path);
} else {
output(o, 1, _("CONFLICT (%s/delete): %s deleted in %s "
"and %s in %s. Version %s of %s left in tree at %s."),
diff --git a/t/t7614-merge-sparse-checkout.sh b/t/t7614-merge-sparse-checkout.sh
new file mode 100755
index 0000000000..6922f0244f
--- /dev/null
+++ b/t/t7614-merge-sparse-checkout.sh
@@ -0,0 +1,27 @@
+#!/bin/sh
+
+test_description='merge can handle sparse-checkout'
+
+. ./test-lib.sh
+
+# merges with conflicts
+
+test_expect_success 'setup' '
+ test_commit a &&
+ test_commit file &&
+ git checkout -b delete-file &&
+ git rm file.t &&
+ test_tick &&
+ git commit -m "remove file" &&
+ git checkout master &&
+ test_commit modify file.t changed
+'
+
+test_expect_success 'merge conflict deleted file and modified' '
+ echo "/a" >.git/info/sparse-checkout &&
+ test_config core.sparsecheckout true &&
+ test_must_fail git merge delete-file &&
+ test_path_is_file file.t
+'
+
+test_done
--
2.12.2.windows.2.1.g7df5db8d31
next prev parent reply other threads:[~2017-04-07 19:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 19:23 [PATCH 0/3] fix working directory file issues while using sparse-checkout Kevin Willford
2017-04-07 19:23 ` Kevin Willford [this message]
2017-04-10 10:36 ` [PATCH 1/3] merge-recursive.c: conflict using sparse should update file Duy Nguyen
2017-04-07 19:23 ` [PATCH 2/3] apply.c: do not checkout file when skip-worktree bit set Kevin Willford
2017-04-07 22:28 ` Stefan Beller
2017-04-10 10:11 ` Duy Nguyen
2017-04-07 19:23 ` [PATCH 3/3] reset.c: update files when using sparse to avoid data loss Kevin Willford
2017-04-07 22:41 ` Stefan Beller
2017-04-10 10:24 ` Duy Nguyen
2017-04-11 22:30 ` Kevin Willford
2017-04-12 13:21 ` Duy Nguyen
2017-04-12 15:37 ` Kevin Willford
2017-04-16 4:25 ` Duy Nguyen
2017-04-17 12:09 ` Duy Nguyen
2017-04-07 19:27 ` [PATCH 0/3] fix working directory file issues while using sparse-checkout Stefan Beller
2017-04-07 19:27 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407192357.948-2-kewillf@microsoft.com \
--to=kcwillford@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kewillf@microsoft.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).