From: Duy Nguyen <pclouds@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: git@vger.kernel.org, peff@peff.net
Subject: Re: [PATCH 2/3] column: allow for custom printf
Date: Mon, 10 Apr 2017 18:13:18 +0700 [thread overview]
Message-ID: <20170410111318.GA23601@ash> (raw)
In-Reply-To: <20170330014238.30032-3-sbeller@google.com>
On Wed, Mar 29, 2017 at 06:42:37PM -0700, Stefan Beller wrote:
> diff --git a/column.h b/column.h
> index 0a61917fa7..c44a1525a9 100644
> --- a/column.h
> +++ b/column.h
> @@ -24,6 +24,9 @@ struct column_options {
> int padding;
> const char *indent;
> const char *nl;
> +
> + /* when non-NULL, use this printing function, fallback to printf */
> + int (*_printf)(const char *__format, ...);
This function should take 'struct column_options *' as the first
argument so a future implementation have full information. Yes we need
to add a couple more lines for just wrapping plain printf, but I think
it's worth it.
> };
>
> struct option;
> --
> 2.12.2.511.g2abb8caf66
>
next prev parent reply other threads:[~2017-04-10 11:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 1:42 [PATCH 0/3] Respect column.ui in commented status in git-commit Stefan Beller
2017-03-30 1:42 ` [PATCH 1/3] column.c: pass column_options to down to display_plain Stefan Beller
2017-03-30 1:42 ` [PATCH 2/3] column: allow for custom printf Stefan Beller
2017-03-30 3:12 ` Jeff King
2017-04-10 11:13 ` Duy Nguyen [this message]
2017-03-30 1:42 ` [PATCH 3/3] WIP - Allow custom printf function for column printing Stefan Beller
2017-03-30 3:22 ` Jeff King
2017-03-30 18:53 ` Stefan Beller
2017-04-10 11:35 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410111318.GA23601@ash \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).