git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCH 0/3] fix memory leak in git-am
Date: Wed, 26 Apr 2017 23:25:04 -0400	[thread overview]
Message-ID: <20170427032503.rgz3bnctnxdn3hin@sigill.intra.peff.net> (raw)

This was noticed by Coverity. The leak isn't new, but I think was
"re-found" by Coverity because some nearby code did an unrelated
s/sha1/oid/ change, throwing off its heuristics.

I also checked whether this was in Dscho's big pack of Coverity fixups
from earlier today, and it's not.

The first one is the actual fix. The second one is pure cleanup, but I
think worth doing. The final one is arguably just churn, and maybe
people even like the end result less. I'm OK to drop it.

  [1/3]: am: fix commit buffer leak in get_commit_info()
  [2/3]: am: simplify allocations in get_commit_info()
  [3/3]: am: shorten ident_split variable name in get_commit_info()

 builtin/am.c | 34 ++++++++++++++--------------------
 1 file changed, 14 insertions(+), 20 deletions(-)

-Peff

             reply	other threads:[~2017-04-27  3:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27  3:25 Jeff King [this message]
2017-04-27  3:25 ` [PATCH 1/3] am: fix commit buffer leak in get_commit_info() Jeff King
2017-04-27  3:27 ` [PATCH 2/3] am: simplify allocations " Jeff King
2017-04-27  3:28 ` [PATCH 3/3] am: shorten ident_split variable name " Jeff King
2017-04-27  5:41 ` [PATCH 0/3] fix memory leak in git-am Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170427032503.rgz3bnctnxdn3hin@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).