Git development
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>,
	Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [Query] Override sendemail.tocmd
Date: Wed, 10 May 2017 16:13:43 +0530	[thread overview]
Message-ID: <20170510104343.GE17481@vireshk-i7> (raw)
In-Reply-To: <20170510103400.GD17481@vireshk-i7>

On 10-05-17, 16:04, Viresh Kumar wrote:
> On 10-05-17, 12:18, Ævar Arnfjörð Bjarmason wrote:
> > On Wed, May 10, 2017 at 9:23 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > > Hi,
> > >
> > > I have a use case and wanted help from you guys..
> > >
> > > I have set the sendemail.tocmd option in my kernel's .git/config
> > > file and that works very well. But sometimes I want to avoid that
> > > (for example sending the patch to someone without the list and
> > > maintainers).
> > >
> > > The suppress-cc=all option works quite well to avoid almost
> > > everything (including running --cc-cmd), but it doesn't suppress
> > > --to-cmd.
> > >
> > > Are there any specific reasons why it is being done that way?
> > >
> > > Currently I need to go edit my .git/config file and remove tocmd
> > > before sending any such patches and it sucks :)
> > 
> > Does something like this work:
> > 
> >     git -c sendemail.tocmd=/bin/false send-email ...
> > 
> > ?
> 
> That failed. I tried with 2.12 version first and then on the next branch with
> version: 2.13.0.303.g4ebf3021692d
> 
> $ git -c sendemail.tocmd=/bin/false send-email --to vingu 0001-abc.patch
> 0001-abc.patch
> (mbox) Adding cc: Viresh Kumar <viresh.kumar@linaro.org> from line 'From: Viresh Kumar <viresh.kumar@linaro.org>'
> (body) Adding cc: Viresh Kumar <viresh.kumar@linaro.org> from line 'Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>'
> (to-cmd) failed to close pipe to '/bin/false' at /usr/libexec/git-core/git-send-email line 1687.

And even if this worked, I believe that the right solution would be to fix
suppress-cc to include tocmd also. That's the whole purpose of suppress-cc
option.

-- 
viresh

  reply	other threads:[~2017-05-10 10:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-10  7:23 [Query] Override sendemail.tocmd Viresh Kumar
2017-05-10  7:29 ` Viresh Kumar
2017-05-10 10:41   ` Viresh Kumar
2017-05-10 10:18 ` Ævar Arnfjörð Bjarmason
2017-05-10 10:34   ` Viresh Kumar
2017-05-10 10:43     ` Viresh Kumar [this message]
2017-05-10 12:21       ` Ævar Arnfjörð Bjarmason
2017-05-18  9:40 ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170510104343.GE17481@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox