[Query] Override sendemail.tocmd

[Query] Override sendemail.tocmd

[Viresh Kumar]

Hi,

I have a use case and wanted help from you guys..

I have set the sendemail.tocmd option in my kernel's .git/config
file and that works very well. But sometimes I want to avoid that
(for example sending the patch to someone without the list and
maintainers).

The suppress-cc=all option works quite well to avoid almost
everything (including running --cc-cmd), but it doesn't suppress
--to-cmd.

Are there any specific reasons why it is being done that way?

Currently I need to go edit my .git/config file and remove tocmd
before sending any such patches and it sucks :)

--
viresh

Re: [Query] Override sendemail.tocmd

[Viresh Kumar]

On 10 May 2017 at 12:53, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> Hi,
>
> I have a use case and wanted help from you guys..
>
> I have set the sendemail.tocmd option in my kernel's .git/config
> file and that works very well. But sometimes I want to avoid that
> (for example sending the patch to someone without the list and
> maintainers).
>
> The suppress-cc=all option works quite well to avoid almost
> everything (including running --cc-cmd), but it doesn't suppress
> --to-cmd.
>
> Are there any specific reasons why it is being done that way?
>
> Currently I need to go edit my .git/config file and remove tocmd
> before sending any such patches and it sucks :)

And it would be *really* useful if we can add the "review" (or whatever
it is called) screen with suppress-cc command as well. Currently the mail
goes away directly without giving us a chance to look at the final list of
recipients the mail is going to :)

--
viresh

Re: [Query] Override sendemail.tocmd

[Ævar Arnfjörð Bjarmason]

On Wed, May 10, 2017 at 9:23 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> Hi,
>
> I have a use case and wanted help from you guys..
>
> I have set the sendemail.tocmd option in my kernel's .git/config
> file and that works very well. But sometimes I want to avoid that
> (for example sending the patch to someone without the list and
> maintainers).
>
> The suppress-cc=all option works quite well to avoid almost
> everything (including running --cc-cmd), but it doesn't suppress
> --to-cmd.
>
> Are there any specific reasons why it is being done that way?
>
> Currently I need to go edit my .git/config file and remove tocmd
> before sending any such patches and it sucks :)

Does something like this work:

    git -c sendemail.tocmd=/bin/false send-email ...

?

Re: [Query] Override sendemail.tocmd

[Viresh Kumar]

On 10-05-17, 12:18, Ævar Arnfjörð Bjarmason wrote:
> On Wed, May 10, 2017 at 9:23 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > Hi,
> >
> > I have a use case and wanted help from you guys..
> >
> > I have set the sendemail.tocmd option in my kernel's .git/config
> > file and that works very well. But sometimes I want to avoid that
> > (for example sending the patch to someone without the list and
> > maintainers).
> >
> > The suppress-cc=all option works quite well to avoid almost
> > everything (including running --cc-cmd), but it doesn't suppress
> > --to-cmd.
> >
> > Are there any specific reasons why it is being done that way?
> >
> > Currently I need to go edit my .git/config file and remove tocmd
> > before sending any such patches and it sucks :)
> 
> Does something like this work:
> 
>     git -c sendemail.tocmd=/bin/false send-email ...
> 
> ?

That failed. I tried with 2.12 version first and then on the next branch with
version: 2.13.0.303.g4ebf3021692d

$ git -c sendemail.tocmd=/bin/false send-email --to vingu 0001-abc.patch
0001-abc.patch
(mbox) Adding cc: Viresh Kumar <viresh.kumar@linaro.org> from line 'From: Viresh Kumar <viresh.kumar@linaro.org>'
(body) Adding cc: Viresh Kumar <viresh.kumar@linaro.org> from line 'Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>'
(to-cmd) failed to close pipe to '/bin/false' at /usr/libexec/git-core/git-send-email line 1687.

-- 
viresh

Re: [Query] Override sendemail.tocmd

[Viresh Kumar]

On 10 May 2017 at 12:59, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 10 May 2017 at 12:53, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>> Hi,
>>
>> I have a use case and wanted help from you guys..
>>
>> I have set the sendemail.tocmd option in my kernel's .git/config
>> file and that works very well. But sometimes I want to avoid that
>> (for example sending the patch to someone without the list and
>> maintainers).
>>
>> The suppress-cc=all option works quite well to avoid almost
>> everything (including running --cc-cmd), but it doesn't suppress
>> --to-cmd.
>>
>> Are there any specific reasons why it is being done that way?
>>
>> Currently I need to go edit my .git/config file and remove tocmd
>> before sending any such patches and it sucks :)
>
> And it would be *really* useful if we can add the "review" (or whatever
> it is called) screen with suppress-cc command as well. Currently the mail
> goes away directly without giving us a chance to look at the final list of
> recipients the mail is going to :)

Fixed that with: sendemail.confirm = always

Re: [Query] Override sendemail.tocmd

[Viresh Kumar]

On 10-05-17, 16:04, Viresh Kumar wrote:
> On 10-05-17, 12:18, Ævar Arnfjörð Bjarmason wrote:
> > On Wed, May 10, 2017 at 9:23 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > > Hi,
> > >
> > > I have a use case and wanted help from you guys..
> > >
> > > I have set the sendemail.tocmd option in my kernel's .git/config
> > > file and that works very well. But sometimes I want to avoid that
> > > (for example sending the patch to someone without the list and
> > > maintainers).
> > >
> > > The suppress-cc=all option works quite well to avoid almost
> > > everything (including running --cc-cmd), but it doesn't suppress
> > > --to-cmd.
> > >
> > > Are there any specific reasons why it is being done that way?
> > >
> > > Currently I need to go edit my .git/config file and remove tocmd
> > > before sending any such patches and it sucks :)
> > 
> > Does something like this work:
> > 
> >     git -c sendemail.tocmd=/bin/false send-email ...
> > 
> > ?
> 
> That failed. I tried with 2.12 version first and then on the next branch with
> version: 2.13.0.303.g4ebf3021692d
> 
> $ git -c sendemail.tocmd=/bin/false send-email --to vingu 0001-abc.patch
> 0001-abc.patch
> (mbox) Adding cc: Viresh Kumar <viresh.kumar@linaro.org> from line 'From: Viresh Kumar <viresh.kumar@linaro.org>'
> (body) Adding cc: Viresh Kumar <viresh.kumar@linaro.org> from line 'Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>'
> (to-cmd) failed to close pipe to '/bin/false' at /usr/libexec/git-core/git-send-email line 1687.

And even if this worked, I believe that the right solution would be to fix
suppress-cc to include tocmd also. That's the whole purpose of suppress-cc
option.

-- 
viresh

Re: [Query] Override sendemail.tocmd

[Ævar Arnfjörð Bjarmason]

On Wed, May 10, 2017 at 12:43 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 10-05-17, 16:04, Viresh Kumar wrote:
>> On 10-05-17, 12:18, Ćvar Arnfjörđ Bjarmason wrote:
>> > On Wed, May 10, 2017 at 9:23 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>> > > Hi,
>> > >
>> > > I have a use case and wanted help from you guys..
>> > >
>> > > I have set the sendemail.tocmd option in my kernel's .git/config
>> > > file and that works very well. But sometimes I want to avoid that
>> > > (for example sending the patch to someone without the list and
>> > > maintainers).
>> > >
>> > > The suppress-cc=all option works quite well to avoid almost
>> > > everything (including running --cc-cmd), but it doesn't suppress
>> > > --to-cmd.
>> > >
>> > > Are there any specific reasons why it is being done that way?
>> > >
>> > > Currently I need to go edit my .git/config file and remove tocmd
>> > > before sending any such patches and it sucks :)
>> >
>> > Does something like this work:
>> >
>> >     git -c sendemail.tocmd=/bin/false send-email ...
>> >
>> > ?
>>
>> That failed. I tried with 2.12 version first and then on the next branch with
>> version: 2.13.0.303.g4ebf3021692d
>>
>> $ git -c sendemail.tocmd=/bin/false send-email --to vingu 0001-abc.patch
>> 0001-abc.patch
>> (mbox) Adding cc: Viresh Kumar <viresh.kumar@linaro.org> from line 'From: Viresh Kumar <viresh.kumar@linaro.org>'
>> (body) Adding cc: Viresh Kumar <viresh.kumar@linaro.org> from line 'Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>'
>> (to-cmd) failed to close pipe to '/bin/false' at /usr/libexec/git-core/git-send-email line 1687.
>
> And even if this worked, I believe that the right solution would be to fix
> suppress-cc to include tocmd also. That's the whole purpose of suppress-cc
> option.

Indeed, it looks like either there should be a new option or the
existing option amended to work with tocmd as you suggest. I was just
wondering if there was a way to do this now, even if with some
non-obvious hack.

Re: [Query] Override sendemail.tocmd

[Viresh Kumar]

On 10 May 2017 at 12:53, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> Hi,
>
> I have a use case and wanted help from you guys..
>
> I have set the sendemail.tocmd option in my kernel's .git/config
> file and that works very well. But sometimes I want to avoid that
> (for example sending the patch to someone without the list and
> maintainers).
>
> The suppress-cc=all option works quite well to avoid almost
> everything (including running --cc-cmd), but it doesn't suppress
> --to-cmd.
>
> Are there any specific reasons why it is being done that way?
>
> Currently I need to go edit my .git/config file and remove tocmd
> before sending any such patches and it sucks :)

Ping !!