From: Brandon Williams <bmwill@google.com>
To: Samuel Lijin <sxlijin@gmail.com>
Cc: "Simon Ruderich" <simon@ruderich.org>,
"Manish Goregaokar" <manishearth@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
"Michael Haggerty" <mhagger@alum.mit.edu>,
"Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH v2 1/2] refs: Add for_each_worktree_ref for iterating over all worktree HEADs
Date: Thu, 18 May 2017 14:06:24 -0700 [thread overview]
Message-ID: <20170518210624.GF112091@google.com> (raw)
In-Reply-To: <CAJZjrdUXXEU9g+n5Xhq3eq4pW8zdaev9gVcwdcNeiDvPpgDzgQ@mail.gmail.com>
On 05/18, Samuel Lijin wrote:
> On Thu, May 18, 2017 at 5:40 AM, Simon Ruderich <simon@ruderich.org> wrote:
> > On Wed, May 17, 2017 at 06:45:31PM -0700, Manish Goregaokar wrote:
> >> Hm, my invocation of git-send-email keeps getting the threading wrong.
> >> Is there a recommended set of arguments to the command?
> >
> > The threading looks fine here (for both cases where you mentioned
> > it being wrong). Why do you think it's wrong? How does it look on
> > your end?
>
> If you're on gmail (as Manish and I both are) patches in a subsequent
Gmail does not do threading, well not true threading. It does grouping
of emails by subject line, that's it. If you want to view threading
(based on message-id) properly then you'll probably need to use a
different email client.
> version will be threaded (wrongly) against "earlier" versions of the
> patch. So if you have patch series A0, A1, A2, A3 and new version B0,
> B1, B2, if you thread them as
>
> A0
> - A1
> - A2
> - A3
> - B0
> - B1
> - B2
>
> gmail will show them in your inbox as
>
> A0
> - B0
>
> A1
> - B1
>
> A2
>
> A3
> - B2
>
> Depending on whatever heuristics they use to match up "threads",
> presumably because most emails aren't threaded correctly.
--
Brandon Williams
next prev parent reply other threads:[~2017-05-18 21:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 0:07 [PATCH 1/2] refs: Add for_each_worktree_ref for iterating over all worktree HEADs Manish Goregaokar
2017-05-17 0:08 ` Manish Goregaokar
2017-05-17 0:28 ` Jonathan Nieder
2017-05-17 0:50 ` manish.earth
2017-05-17 0:50 ` [PATCH 2/2] reachable: Add HEADs of all worktrees to reachability analysis manish.earth
2017-05-17 0:55 ` [PATCH 1/2] refs: Add for_each_worktree_ref for iterating over all worktree HEADs Manish Goregaokar
2017-05-17 21:48 ` Manish Goregaokar
2017-05-18 0:07 ` Brandon Williams
2017-05-18 1:16 ` Manish Goregaokar
2017-05-18 1:42 ` [PATCH v2 " manishearth
2017-05-18 1:42 ` [PATCH v2 2/2] reachable: Add HEADs of all worktrees to reachability analysis manishearth
2017-05-18 1:45 ` [PATCH v2 1/2] refs: Add for_each_worktree_ref for iterating over all worktree HEADs Manish Goregaokar
2017-05-18 9:40 ` Simon Ruderich
2017-05-18 20:29 ` Samuel Lijin
2017-05-18 21:06 ` Brandon Williams [this message]
2017-05-20 10:30 ` Junio C Hamano
2017-05-20 17:33 ` Manish Goregaokar
2017-05-20 23:49 ` Junio C Hamano
2017-05-22 11:17 ` Duy Nguyen
2017-05-22 22:52 ` Manish Goregaokar
2017-05-25 12:51 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518210624.GF112091@google.com \
--to=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=manishearth@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=simon@ruderich.org \
--cc=sxlijin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).