From: Brandon Williams <bmwill@google.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, peff@peff.net, sandals@crustytoothpaste.net,
Brandon Williams <bmwill@google.com>
Subject: [PATCH 00/33] object id conversion (grep and diff)
Date: Tue, 30 May 2017 10:30:36 -0700 [thread overview]
Message-ID: <20170530173109.54904-1-bmwill@google.com> (raw)
A month or so ago I thought I would lend a hand to Brian and do a round of
conversions from sha1 -> struct object_id. Now that Brian's latest series has
hit master I can finally send these patches out.
The first couple patches are from Brian which convert some of the notes logic
to using 'struct object_id'. The remaining patches are to convert the grep and
diff machinery to using 'struct object_id'.
Brandon Williams (26):
grep: convert to struct object_id
diff: convert get_stat_data to struct object_id
diff: convert diff_index_show_file to struct object_id
diff: convert diff_addremove to struct object_id
diff: convert run_diff_files to struct object_id
diff: convert diff_change to struct object_id
diff: convert fill_filespec to struct object_id
diff: convert reuse_worktree_file to struct object_id
diff: finish conversion for prepare_temp_file to struct object_id
patch-ids: convert to struct object_id
diff: convert diff_flush_patch_id to struct object_id
combine-diff: convert diff_tree_combined to struct object_id
combine-diff: convert find_paths_* to struct object_id
tree-diff: convert diff_root_tree_sha1 to struct object_id
notes-merge: convert notes_merge* to struct object_id
notes-merge: convert merge_from_diffs to struct object_id
notes-merge: convert find_notes_merge_pair_ps to struct object_id
notes-merge: convert verify_notes_filepair to struct object_id
notes-merge: convert write_note_to_worktree to struct object_id
diff-tree: convert diff_tree_sha1 to struct object_id
builtin/diff-tree: cleanup references to sha1
tree-diff: convert try_to_follow_renames to struct object_id
tree-diff: convert diff_tree_paths to struct object_id
tree-diff: convert path_appendnew to object_id
diffcore-rename: use is_empty_blob_oid
diff: rename diff_fill_sha1_info to diff_fill_oid_info
brian m. carlson (7):
notes: convert internal structures to struct object_id
notes: convert internal parts to struct object_id
notes: convert for_each_note to struct object_id
notes: make get_note return pointer to struct object_id
notes: convert format_display_notes to struct object_id
builtin/notes: convert to struct object_id
notes: convert some accessor functions to struct object_id
builtin/am.c | 2 +-
builtin/blame.c | 22 +++---
builtin/commit.c | 2 +-
builtin/diff-tree.c | 16 ++--
builtin/diff.c | 8 +-
builtin/fast-export.c | 8 +-
builtin/grep.c | 22 +++---
builtin/log.c | 8 +-
builtin/merge.c | 2 +-
builtin/notes.c | 136 ++++++++++++++++-----------------
cache.h | 7 ++
combine-diff.c | 30 ++++----
diff-lib.c | 52 ++++++-------
diff-no-index.c | 2 +-
diff.c | 74 +++++++++---------
diff.h | 38 +++++-----
diffcore-rename.c | 6 +-
diffcore.h | 2 +-
grep.c | 19 +++--
grep.h | 2 +-
line-log.c | 10 +--
log-tree.c | 12 +--
merge-recursive.c | 2 +-
notes-cache.c | 10 +--
notes-merge.c | 165 +++++++++++++++++++++--------------------
notes-merge.h | 12 +--
notes-utils.c | 2 +-
notes-utils.h | 2 +-
notes.c | 202 ++++++++++++++++++++++++++------------------------
notes.h | 16 ++--
patch-ids.c | 26 +++----
patch-ids.h | 4 +-
remote-testsvn.c | 22 +++---
revision.c | 16 ++--
sequencer.c | 4 +-
tree-diff.c | 93 ++++++++++++-----------
36 files changed, 535 insertions(+), 521 deletions(-)
--
2.13.0.219.gdb65acc882-goog
next reply other threads:[~2017-05-30 17:31 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 17:30 Brandon Williams [this message]
2017-05-30 17:30 ` [PATCH 01/33] notes: convert internal structures to struct object_id Brandon Williams
2017-05-30 17:30 ` [PATCH 02/33] notes: convert internal parts " Brandon Williams
2017-05-30 17:30 ` [PATCH 03/33] notes: convert for_each_note " Brandon Williams
2017-05-30 17:30 ` [PATCH 04/33] notes: make get_note return pointer " Brandon Williams
2017-07-15 18:15 ` René Scharfe
2017-07-17 17:49 ` Brandon Williams
2017-05-30 17:30 ` [PATCH 05/33] notes: convert format_display_notes " Brandon Williams
2017-05-30 17:30 ` [PATCH 06/33] builtin/notes: convert " Brandon Williams
2017-05-30 17:30 ` [PATCH 07/33] notes: convert some accessor functions " Brandon Williams
2017-05-30 17:30 ` [PATCH 08/33] grep: convert " Brandon Williams
2017-06-02 1:00 ` Junio C Hamano
2017-05-30 17:30 ` [PATCH 09/33] diff: convert get_stat_data " Brandon Williams
2017-05-30 17:30 ` [PATCH 10/33] diff: convert diff_index_show_file " Brandon Williams
2017-05-30 17:30 ` [PATCH 11/33] diff: convert diff_addremove " Brandon Williams
2017-05-30 17:30 ` [PATCH 12/33] diff: convert run_diff_files " Brandon Williams
2017-05-30 17:30 ` [PATCH 13/33] diff: convert diff_change " Brandon Williams
2017-05-30 17:30 ` [PATCH 14/33] diff: convert fill_filespec " Brandon Williams
2017-05-30 17:30 ` [PATCH 15/33] diff: convert reuse_worktree_file " Brandon Williams
2017-05-30 17:30 ` [PATCH 16/33] diff: finish conversion for prepare_temp_file " Brandon Williams
2017-05-31 0:41 ` Stefan Beller
2017-05-30 17:30 ` [PATCH 17/33] patch-ids: convert " Brandon Williams
2017-05-30 17:30 ` [PATCH 18/33] diff: convert diff_flush_patch_id " Brandon Williams
2017-05-30 17:30 ` [PATCH 19/33] combine-diff: convert diff_tree_combined " Brandon Williams
2017-05-30 17:30 ` [PATCH 20/33] combine-diff: convert find_paths_* " Brandon Williams
2017-05-31 17:49 ` Stefan Beller
2017-06-02 1:37 ` Junio C Hamano
2017-05-30 17:30 ` [PATCH 21/33] tree-diff: convert diff_root_tree_sha1 " Brandon Williams
2017-05-30 17:30 ` [PATCH 22/33] notes-merge: convert notes_merge* " Brandon Williams
2017-05-31 17:54 ` Stefan Beller
2017-05-31 22:00 ` brian m. carlson
2017-06-02 1:13 ` Junio C Hamano
2017-06-02 18:32 ` Brandon Williams
2017-05-30 17:30 ` [PATCH 23/33] notes-merge: convert merge_from_diffs " Brandon Williams
2017-05-31 18:04 ` Stefan Beller
2017-06-02 0:42 ` Junio C Hamano
2017-05-30 17:31 ` [PATCH 24/33] notes-merge: convert find_notes_merge_pair_ps " Brandon Williams
2017-05-30 17:31 ` [PATCH 25/33] notes-merge: convert verify_notes_filepair " Brandon Williams
2017-05-31 18:09 ` Stefan Beller
2017-06-02 0:47 ` Junio C Hamano
2017-06-02 18:55 ` Brandon Williams
2017-06-02 23:49 ` Junio C Hamano
2017-05-30 17:31 ` [PATCH 26/33] notes-merge: convert write_note_to_worktree " Brandon Williams
2017-05-30 17:31 ` [PATCH 27/33] diff-tree: convert diff_tree_sha1 " Brandon Williams
2017-05-30 17:31 ` [PATCH 28/33] builtin/diff-tree: cleanup references to sha1 Brandon Williams
2017-06-02 1:26 ` Junio C Hamano
2017-05-30 17:31 ` [PATCH 29/33] tree-diff: convert try_to_follow_renames to struct object_id Brandon Williams
2017-05-30 17:31 ` [PATCH 30/33] tree-diff: convert diff_tree_paths " Brandon Williams
2017-05-31 18:24 ` Stefan Beller
2017-05-31 21:29 ` Jeff King
2017-05-31 21:39 ` Jeff King
2017-06-02 1:31 ` Junio C Hamano
2017-07-15 17:18 ` René Scharfe
2017-07-15 17:22 ` brian m. carlson
2017-05-30 17:31 ` [PATCH 31/33] tree-diff: convert path_appendnew to object_id Brandon Williams
2017-06-02 1:32 ` Junio C Hamano
2017-05-30 17:31 ` [PATCH 32/33] diffcore-rename: use is_empty_blob_oid Brandon Williams
2017-05-30 17:31 ` [PATCH 33/33] diff: rename diff_fill_sha1_info to diff_fill_oid_info Brandon Williams
2017-05-31 22:06 ` [PATCH 00/33] object id conversion (grep and diff) brian m. carlson
2017-06-02 19:24 ` Brandon Williams
2017-06-02 1:34 ` Junio C Hamano
2017-06-02 5:08 ` Junio C Hamano
2017-06-02 7:19 ` Junio C Hamano
2017-06-02 18:22 ` Brandon Williams
2017-06-02 23:35 ` Junio C Hamano
2017-06-05 19:42 ` Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530173109.54904-1-bmwill@google.com \
--to=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).