* [PATCH] docs/pretty-formats: stress that %- removes all preceding line-feeds
@ 2017-06-15 10:36 SZEDER Gábor
2017-06-16 18:30 ` Jonathan Nieder
0 siblings, 1 reply; 2+ messages in thread
From: SZEDER Gábor @ 2017-06-15 10:36 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, SZEDER Gábor
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---
A mere plural "line-feeds" was too subtle for me to grasp on first
(and second...) reading.
Documentation/pretty-formats.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt
index 38040e95b..a48d267e2 100644
--- a/Documentation/pretty-formats.txt
+++ b/Documentation/pretty-formats.txt
@@ -213,8 +213,8 @@ If you add a `+` (plus sign) after '%' of a placeholder, a line-feed
is inserted immediately before the expansion if and only if the
placeholder expands to a non-empty string.
-If you add a `-` (minus sign) after '%' of a placeholder, line-feeds that
-immediately precede the expansion are deleted if and only if the
+If you add a `-` (minus sign) after '%' of a placeholder, all consecutive
+line-feeds immediately preceding the expansion are deleted if and only if the
placeholder expands to an empty string.
If you add a ` ` (space) after '%' of a placeholder, a space
--
2.13.1.505.g7cc9fcafb
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] docs/pretty-formats: stress that %- removes all preceding line-feeds
2017-06-15 10:36 [PATCH] docs/pretty-formats: stress that %- removes all preceding line-feeds SZEDER Gábor
@ 2017-06-16 18:30 ` Jonathan Nieder
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Nieder @ 2017-06-16 18:30 UTC (permalink / raw)
To: SZEDER Gábor; +Cc: Junio C Hamano, git
SZEDER Gábor wrote:
> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
> ---
> A mere plural "line-feeds" was too subtle for me to grasp on first
> (and second...) reading.
This could go in the commit message.
> Documentation/pretty-formats.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
With or without such a tweak,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
> diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt
> index 38040e95b..a48d267e2 100644
> --- a/Documentation/pretty-formats.txt
> +++ b/Documentation/pretty-formats.txt
> @@ -213,8 +213,8 @@ If you add a `+` (plus sign) after '%' of a placeholder, a line-feed
> is inserted immediately before the expansion if and only if the
> placeholder expands to a non-empty string.
>
> -If you add a `-` (minus sign) after '%' of a placeholder, line-feeds that
> -immediately precede the expansion are deleted if and only if the
> +If you add a `-` (minus sign) after '%' of a placeholder, all consecutive
> +line-feeds immediately preceding the expansion are deleted if and only if the
> placeholder expands to an empty string.
>
> If you add a ` ` (space) after '%' of a placeholder, a space
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-16 18:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-15 10:36 [PATCH] docs/pretty-formats: stress that %- removes all preceding line-feeds SZEDER Gábor
2017-06-16 18:30 ` Jonathan Nieder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).