[PATCH] comment: fix a typo in the comment

[PATCH] comment: fix a typo in the comment

[Kaartic Sivaraam]

---
 Though very trivial, I wanted to correct this as I didn't
 want to ignore it after seeing it.

 builtin/commit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/commit.c b/builtin/commit.c
index 8d1cac0..aff6bf7 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -984,7 +984,7 @@ static int rest_is_empty(struct strbuf *sb, int start)
 	int i, eol;
 	const char *nl;
 
-	/* Check if the rest is just whitespace and Signed-of-by's. */
+	/* Check if the rest is just whitespace and Signed-off-by's. */
 	for (i = start; i < sb->len; i++) {
 		nl = memchr(sb->buf + i, '\n', sb->len - i);
 		if (nl)
-- 
2.7.4

Re: [PATCH] comment: fix a typo in the comment

[Junio C Hamano]

Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:

> ---
>  Though very trivial, I wanted to correct this as I didn't
>  want to ignore it after seeing it.

Thanks for sharp eyes.  Sign-off?  (or Sign-of? ;-))

>
>  builtin/commit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/commit.c b/builtin/commit.c
> index 8d1cac0..aff6bf7 100644
> --- a/builtin/commit.c
> +++ b/builtin/commit.c
> @@ -984,7 +984,7 @@ static int rest_is_empty(struct strbuf *sb, int start)
>  	int i, eol;
>  	const char *nl;
>  
> -	/* Check if the rest is just whitespace and Signed-of-by's. */
> +	/* Check if the rest is just whitespace and Signed-off-by's. */
>  	for (i = start; i < sb->len; i++) {
>  		nl = memchr(sb->buf + i, '\n', sb->len - i);
>  		if (nl)

Re: [PATCH] comment: fix a typo in the comment

[Kaartic Sivaraam]

On Wed, 2017-07-05 at 11:18 -0700, Junio C Hamano wrote:
> Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:
> 
> > ---
> >  Though very trivial, I wanted to correct this as I didn't
> >  want to ignore it after seeing it.
> 
> Thanks for sharp eyes.  Sign-off?  (or Sign-of? ;-))
> 
I should also thank you for your sharp eyes! BTW, this won't repeat
again as I have made 'git' worry about adding the signed-off-by to the
commits I do on my local version of git.git :)

-- 
Kaartic

Re: [PATCH] comment: fix a typo in the comment

[SZEDER Gábor]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 456 bytes --]

> On Wed, 2017-07-05 at 11:18 -0700, Junio C Hamano wrote:
> > Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:
> > 
> > > ---
> > >  Though very trivial, I wanted to correct this as I didn't
> > >  want to ignore it after seeing it.
> > 
> > Thanks for sharp eyes.  Sign-off?  (or Sign-of? ;-))
> > 
> I should also thank you for your sharp eyes!

Speaking of sharp eyes...  That Subject: line really needs a
s/comment:/commit:/, doesn't it? :)

Re: [PATCH] comment: fix a typo in the comment

[Junio C Hamano]

SZEDER Gábor <szeder.dev@gmail.com> writes:

> Speaking of sharp eyes...  That Subject: line really needs a
> s/comment:/commit:/, doesn't it? :)

Surely it does.

[PATCH] commit: fix a typo in the comment

[Kaartic Sivaraam]

Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
---
 builtin/commit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/commit.c b/builtin/commit.c
index 8d1cac062..aff6bf7aa 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -984,7 +984,7 @@ static int rest_is_empty(struct strbuf *sb, int start)
 	int i, eol;
 	const char *nl;
 
-	/* Check if the rest is just whitespace and Signed-of-by's. */
+	/* Check if the rest is just whitespace and Signed-off-by's. */
 	for (i = start; i < sb->len; i++) {
 		nl = memchr(sb->buf + i, '\n', sb->len - i);
 		if (nl)
-- 
2.13.2.879.g2ab69f31a.dirty

[PATCH] comment: fix a typo in the comment

[Kaartic Sivaraam]

Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
---
 builtin/commit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/commit.c b/builtin/commit.c
index 8d1cac062..aff6bf7aa 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -984,7 +984,7 @@ static int rest_is_empty(struct strbuf *sb, int start)
 	int i, eol;
 	const char *nl;
 
-	/* Check if the rest is just whitespace and Signed-of-by's. */
+	/* Check if the rest is just whitespace and Signed-off-by's. */
 	for (i = start; i < sb->len; i++) {
 		nl = memchr(sb->buf + i, '\n', sb->len - i);
 		if (nl)
-- 
2.11.0