* [PATCH] doc: camelCase the i18n config variables to improve readability
@ 2017-07-17 15:39 Kaartic Sivaraam
2017-07-17 22:12 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Kaartic Sivaraam @ 2017-07-17 15:39 UTC (permalink / raw)
To: gitster; +Cc: git
The i18n config variable used weren't readable as they were in
the crude form of how git stores/uses it's config variables.
Improve it's readability by replacing them with camelCased versions
of config variables as it doesn't have any impact on it's usage.
Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
---
Documentation/i18n.txt | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/i18n.txt b/Documentation/i18n.txt
index 2dd79db5c..7e36e5b55 100644
--- a/Documentation/i18n.txt
+++ b/Documentation/i18n.txt
@@ -42,11 +42,11 @@ mind.
+
------------
[i18n]
- commitencoding = ISO-8859-1
+ commitEncoding = ISO-8859-1
------------
+
Commit objects created with the above setting record the value
-of `i18n.commitencoding` in its `encoding` header. This is to
+of `i18n.commitEncoding` in its `encoding` header. This is to
help other people who look at them later. Lack of this header
implies that the commit log message is encoded in UTF-8.
@@ -54,15 +54,15 @@ implies that the commit log message is encoded in UTF-8.
`encoding` header of a commit object, and try to re-code the
log message into UTF-8 unless otherwise specified. You can
specify the desired output encoding with
- `i18n.logoutputencoding` in `.git/config` file, like this:
+ `i18n.logOutputEncoding` in `.git/config` file, like this:
+
------------
[i18n]
- logoutputencoding = ISO-8859-1
+ logOutputEncoding = ISO-8859-1
------------
+
If you do not have this configuration variable, the value of
-`i18n.commitencoding` is used instead.
+`i18n.commitEncoding` is used instead.
Note that we deliberately chose not to re-code the commit log
message when a commit is made to force UTF-8 at the commit
--
2.13.3.973.gaaf39e6bd.dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] doc: camelCase the i18n config variables to improve readability
2017-07-17 15:39 [PATCH] doc: camelCase the i18n config variables to improve readability Kaartic Sivaraam
@ 2017-07-17 22:12 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2017-07-17 22:12 UTC (permalink / raw)
To: Kaartic Sivaraam; +Cc: git
Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:
> The i18n config variable used weren't readable as they were in
> the crude form of how git stores/uses it's config variables.
>
> Improve it's readability by replacing them with camelCased versions
> of config variables as it doesn't have any impact on it's usage.
>
> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
> ---
Thanks; this makes sense.
> Documentation/i18n.txt | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/i18n.txt b/Documentation/i18n.txt
> index 2dd79db5c..7e36e5b55 100644
> --- a/Documentation/i18n.txt
> +++ b/Documentation/i18n.txt
> @@ -42,11 +42,11 @@ mind.
> +
> ------------
> [i18n]
> - commitencoding = ISO-8859-1
> + commitEncoding = ISO-8859-1
> ------------
> +
> Commit objects created with the above setting record the value
> -of `i18n.commitencoding` in its `encoding` header. This is to
> +of `i18n.commitEncoding` in its `encoding` header. This is to
> help other people who look at them later. Lack of this header
> implies that the commit log message is encoded in UTF-8.
>
> @@ -54,15 +54,15 @@ implies that the commit log message is encoded in UTF-8.
> `encoding` header of a commit object, and try to re-code the
> log message into UTF-8 unless otherwise specified. You can
> specify the desired output encoding with
> - `i18n.logoutputencoding` in `.git/config` file, like this:
> + `i18n.logOutputEncoding` in `.git/config` file, like this:
> +
> ------------
> [i18n]
> - logoutputencoding = ISO-8859-1
> + logOutputEncoding = ISO-8859-1
> ------------
> +
> If you do not have this configuration variable, the value of
> -`i18n.commitencoding` is used instead.
> +`i18n.commitEncoding` is used instead.
>
> Note that we deliberately chose not to re-code the commit log
> message when a commit is made to force UTF-8 at the commit
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-17 22:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-17 15:39 [PATCH] doc: camelCase the i18n config variables to improve readability Kaartic Sivaraam
2017-07-17 22:12 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).