From: Martin Koegler <martin.koegler@chello.at>
To: Junio C Hamano <gitster@pobox.com>
Cc: Martin Koegler <martin.koegler@chello.at>, git@vger.kernel.org
Subject: Re: [PATCH] Fix delta integer overflows
Date: Tue, 8 Aug 2017 08:25:23 +0200 [thread overview]
Message-ID: <20170808062522.GB4091@mail.zuhause> (raw)
In-Reply-To: <xmqqvalyn89b.fsf@gitster.mtv.corp.google.com>
On Mon, Aug 07, 2017 at 06:44:16PM -0700, Junio C Hamano wrote:
> Having said that, I am a bit curious how you came to this patch.
> Was the issue found by code inspection, or did you actually have a
> real life use case to raise the core.bigFileThreshold configuration
> to a value above 4GB?
Real life use - tracking changes in larger files.
Raising the limit above 4GB suddenly resulted in a broken pack files in the repository and
aborts of various git commands.
Data is still recoverable with all size sanity checks disabled.
Regards,
Martin
prev parent reply other threads:[~2017-08-08 6:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 18:10 [PATCH] Fix delta integer overflows Martin Koegler
2017-08-07 18:36 ` Junio C Hamano
2017-08-07 19:39 ` Johannes Schindelin
2017-08-07 19:48 ` Junio C Hamano
2017-08-07 21:10 ` Johannes Schindelin
2017-08-07 21:36 ` Junio C Hamano
2017-08-07 23:02 ` Junio C Hamano
2017-08-08 6:20 ` Martin Koegler
2017-08-08 11:38 ` Johannes Schindelin
2017-08-08 1:44 ` Junio C Hamano
2017-08-08 6:25 ` Martin Koegler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170808062522.GB4091@mail.zuhause \
--to=martin.koegler@chello.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).