From: Martin Koegler <martin.koegler@chello.at>
To: Martin Koegler <martin.koegler@chello.at>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Johannes.Schindelin@gmx.de
Subject: Re: [PATCH] Convert size datatype to size_t
Date: Wed, 9 Aug 2017 09:26:13 +0200 [thread overview]
Message-ID: <20170809072613.GA20347@mail.zuhause> (raw)
In-Reply-To: <20170809071906.GA19310@mail.zuhause>
On Wed, Aug 09, 2017 at 09:19:06AM +0200, Martin Koegler wrote:
> On Tue, Aug 08, 2017 at 11:04:20PM -0700, Junio C Hamano wrote:
> > As https://travis-ci.org/git/git/jobs/262463159 shows, unfortunately
> > it turns out that things are not so simple X-<. On Linux32, size_t
> > is uint, which is the same size as ulong, but "%lu" is not appropriate
> > for showing a size_t value.
> >
> > So you are correct to say in the comment under three-dashes that
> > there is much more to change in the codebase.
>
> I'll post a new version fixing the *printf issues.
What is the correct format specifier for size_t?
Linux has %zu (C99). Is that OK for the GIT codebase?
Regards,
Martin
next prev parent reply other threads:[~2017-08-09 7:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 20:00 [PATCH] Convert size datatype to size_t Martin Koegler
2017-08-08 21:21 ` Junio C Hamano
2017-08-08 21:46 ` Junio C Hamano
2017-08-09 6:04 ` Junio C Hamano
2017-08-09 7:19 ` Martin Koegler
2017-08-09 7:26 ` Martin Koegler [this message]
2017-08-09 16:51 ` Junio C Hamano
2017-08-09 22:12 ` Johannes Schindelin
2017-08-09 22:16 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809072613.GA20347@mail.zuhause \
--to=martin.koegler@chello.at \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).