From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Yaroslav Halchenko <yoh@onerussian.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: fatal: Out of memory, getdelim failed under NFS mounts
Date: Thu, 10 Aug 2017 16:05:02 -0400 [thread overview]
Message-ID: <20170810200502.rutab4z3ft7gcpjz@sigill.intra.peff.net> (raw)
In-Reply-To: <6d7b0d30-48ea-f79f-78cd-088557ea06ac@web.de>
On Thu, Aug 10, 2017 at 09:58:37PM +0200, René Scharfe wrote:
> > So the function is returning -1 and leaving ENOMEM in errno on
> > Yaroslav's system.
> >
> > I wonder if we are truly hitting out of memory, though. The same
> > symptom could bee seen if getdelim() does not touch errno when it
> > returns -1, but some other system call earlier set it to ENOMEM,
> > for example.
>
> That can happen when the end of a file is reached; getdelim() returns
> -1 and leaves errno unchanged. So we need to set errno to 0 just
> before that call.
Good catch. That's a bug in my original conversoin of
strbuf_getwholeline().
-Peff
next prev parent reply other threads:[~2017-08-10 20:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 17:39 fatal: Out of memory, getdelim failed under NFS mounts Yaroslav Halchenko
2017-08-10 13:27 ` René Scharfe
2017-08-10 14:43 ` Yaroslav Halchenko
2017-08-10 19:44 ` René Scharfe
2017-08-10 18:56 ` Junio C Hamano
2017-08-10 19:44 ` Yaroslav Halchenko
2017-08-10 19:58 ` René Scharfe
2017-08-10 20:05 ` Jeff King [this message]
2017-08-10 20:29 ` Yaroslav Halchenko
2017-08-10 20:56 ` [PATCH] strbuf: clear errno before calling getdelim(3) René Scharfe
2017-08-10 21:02 ` Jeff King
2017-08-10 21:35 ` Yaroslav Halchenko
2017-08-10 21:41 ` Junio C Hamano
2017-08-11 7:50 ` Simon Ruderich
2017-08-11 8:52 ` René Scharfe
2017-08-12 10:02 ` Simon Ruderich
2017-08-12 11:57 ` René Scharfe
2017-08-12 12:21 ` René Scharfe
2017-08-13 4:32 ` Jeff King
2017-08-13 5:51 ` René Scharfe
2017-08-13 5:58 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810200502.rutab4z3ft7gcpjz@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=yoh@onerussian.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).