From: Job Snijders <job@instituut.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Giuseppe Bilotta" <giuseppe.bilotta@gmail.com>,
"Git List" <git@vger.kernel.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
yashi@atmark-techno.com, "Jakub Narebski" <jnareb@gmail.com>
Subject: Re: [PATCH] Add 'raw' blob_plain link in history overview
Date: Tue, 22 Aug 2017 21:35:20 +0200 [thread overview]
Message-ID: <20170822193520.GJ39363@Vurt.local> (raw)
In-Reply-To: <xmqqo9r72yrg.fsf@gitster.mtv.corp.google.com>
On Tue, Aug 22, 2017 at 12:22:43PM -0700, Junio C Hamano wrote:
> Job Snijders <job@instituut.net> writes:
> > Add 'raw' blob_plain link in history overview
> >
> > Reviewed-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
> > Signed-off-by: Job Snijders <job@instituut.net>
> >
> > ---
>
> Thanks; I somehow thought that your earlier one not just said what
> it does (twice---that is not needed) but why this change is useful,
> but that is lost in the patch description?
We often work with very large plain text files in our repositories and
found it friendlier to the users if we can click directly to the raw
version of such files.
Without this patch the workflow is to go to the history of a file, click
the 'blob' link, and then click the 'raw' link. If the file is large
(multiple megabytes) - rendering the html enveloppe to the blob can take
quite some time in the browser DOM rendering.
This patch adds a 'raw' blob_plain link in history overview so you can
immediately click to the 'raw' version, saving time and improving
workflow.
Here is a screenshot of a gitweb instance with this patch applied:
http://instituut.net/~job/screenshots/b0f30e21eb64d5dda75ddabd.png
Kind regards,
Job
next prev parent reply other threads:[~2017-08-22 19:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 18:59 [PATCH] Add 'raw' blob_plain link in history overview Job Snijders
2017-08-20 18:03 ` Job Snijders
2017-08-21 10:19 ` Giuseppe Bilotta
2017-08-21 10:44 ` Job Snijders
2017-08-21 14:07 ` Giuseppe Bilotta
2017-08-21 14:13 ` Job Snijders
2017-08-22 19:22 ` Junio C Hamano
2017-08-22 19:35 ` Job Snijders [this message]
2017-08-22 20:00 ` Giuseppe Bilotta
2017-08-22 20:07 ` Job Snijders
2017-08-22 20:09 ` Junio C Hamano
2017-08-22 20:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170822193520.GJ39363@Vurt.local \
--to=job@instituut.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=giuseppe.bilotta@gmail.com \
--cc=jnareb@gmail.com \
--cc=yashi@atmark-techno.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).