From: Nish Aravamudan <nish.aravamudan@canonical.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>, me@ikke.info
Subject: Re: [PATCH] Fix branch renaming not updating HEADs correctly
Date: Thu, 24 Aug 2017 12:04:18 -0700 [thread overview]
Message-ID: <20170824190418.tdhg45fugibtfgwb@pitfall> (raw)
In-Reply-To: <20170824104124.6263-1-pclouds@gmail.com>
On 24.08.2017 [17:41:24 +0700], Nguyễn Thái Ngọc Duy wrote:
> There are two bugs that sort of work together and cause problems. Let's
> start with one in replace_each_worktree_head_symref.
<snip>
> Correct add_head_info(), remove RESOLVE_REF_READING flag. With the flag
> gone, we should always return good "head_ref" in orphan checkouts (either
> temporary or permanent). With good head_ref, things start to work again.
>
> Noticed-by: Nish Aravamudan <nish.aravamudan@canonical.com>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Tested-by: Nish Aravamudan <nish.aravamudan@canonical.com>
Thank you for the quick turnaround on the patch!
-Nish
--
Nishanth Aravamudan
Ubuntu Server
Canonical Ltd
next prev parent reply other threads:[~2017-08-24 19:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 20:13 Undocumented change in `git branch -M` behavior Nish Aravamudan
2017-08-24 5:32 ` Kevin Daudt
2017-08-24 8:59 ` Duy Nguyen
2017-08-24 10:41 ` [PATCH] Fix branch renaming not updating HEADs correctly Nguyễn Thái Ngọc Duy
2017-08-24 19:04 ` Nish Aravamudan [this message]
2017-08-27 5:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824190418.tdhg45fugibtfgwb@pitfall \
--to=nish.aravamudan@canonical.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ikke.info \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).