git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Daudt <me@ikke.info>
To: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] commit-template: change a message to be more intuitive
Date: Wed, 13 Sep 2017 12:29:15 +0200	[thread overview]
Message-ID: <20170913102915.GA21499@alpha.vpn.ikke.info> (raw)
In-Reply-To: <20170912105536.6094-1-kaarticsivaraam91196@gmail.com>

On Tue, Sep 12, 2017 at 04:25:36PM +0530, Kaartic Sivaraam wrote:
> It's not possible to 'touch' the cut-line that is shown when the
> user requests a patch in his commit template.
> 

Touching something can also mean to disturb or change something, which
is the meaning being used here, so it is not an incorrect use of the
word.

> So, make the sentence more intuitive.

I can understand however that it might be not so clear for people with
less fluency in English.

> 
> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
> ---
>  Just a small tweak. May or may not be worth the patch.
> 
>  wt-status.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/wt-status.c b/wt-status.c
> index 77c27c511..1f54b1df2 100644
> --- a/wt-status.c
> +++ b/wt-status.c
> @@ -934,7 +934,7 @@ size_t wt_status_locate_end(const char *s, size_t len)
>  
>  void wt_status_add_cut_line(FILE *fp)
>  {
> -	const char *explanation = _("Do not touch the line above.\nEverything below will be removed.");
> +	const char *explanation = _("Do not edit the line above.\nEverything below will be removed.");
>  	struct strbuf buf = STRBUF_INIT;
>  
>  	fprintf(fp, "%c %s", comment_line_char, cut_line);
> -- 
> 2.14.1.1006.g90ad9a07c
> 

  reply	other threads:[~2017-09-13 10:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-12 10:55 [PATCH] commit-template: change a message to be more intuitive Kaartic Sivaraam
2017-09-13 10:29 ` Kevin Daudt [this message]
2017-09-13 11:20   ` Jeff King
2017-09-13 12:31     ` Kaartic Sivaraam
2017-09-13 13:05       ` [PATCH v2] " Kaartic Sivaraam
2017-09-13 12:29   ` [PATCH] " Kaartic Sivaraam
     [not found] <<e656d1b4-c95e-e51d-5f48-bb3450580fa4@gmail.com>
2017-09-13 13:05 ` [PATCH v2] " Kaartic Sivaraam
2017-09-14  7:36   ` Michael J Gruber
2017-09-14 14:17     ` Kaartic Sivaraam
2017-09-14 14:41       ` Jeff King
2017-09-15  2:18         ` Junio C Hamano
2017-09-15  4:50           ` [PATCH v3] " Kaartic Sivaraam
2017-09-15 10:00             ` Michael J Gruber
2017-09-15 12:39               ` Kaartic Sivaraam
2017-09-15  1:58     ` [PATCH v2] " Kaartic Sivaraam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170913102915.GA21499@alpha.vpn.ikke.info \
    --to=me@ikke.info \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kaarticsivaraam91196@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).