From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 0B7A5209B8 for ; Thu, 14 Sep 2017 14:34:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751365AbdINOex (ORCPT ); Thu, 14 Sep 2017 10:34:53 -0400 Received: from cloud.peff.net ([104.130.231.41]:38806 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751131AbdINOex (ORCPT ); Thu, 14 Sep 2017 10:34:53 -0400 Received: (qmail 21745 invoked by uid 109); 14 Sep 2017 14:34:52 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Thu, 14 Sep 2017 14:34:52 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 28838 invoked by uid 111); 14 Sep 2017 14:35:28 -0000 Received: from Unknown (HELO sigill.intra.peff.net) (10.0.1.3) by peff.net (qpsmtpd/0.94) with SMTP; Thu, 14 Sep 2017 10:35:28 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Thu, 14 Sep 2017 10:34:50 -0400 Date: Thu, 14 Sep 2017 10:34:50 -0400 From: Jeff King To: Michael J Gruber Cc: git@vger.kernel.org, Ekelhart Jakob , Junio C Hamano Subject: Re: [PATCH 1/3] t6010: test actual test output Message-ID: <20170914143450.tmomqf2vs55tk3nz@sigill.intra.peff.net> References: <80f7dcfaa9162dc795f8c072effea44fa83ea196.1505394278.git.git@grubix.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <80f7dcfaa9162dc795f8c072effea44fa83ea196.1505394278.git.git@grubix.eu> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Sep 14, 2017 at 03:15:18PM +0200, Michael J Gruber wrote: > 4f21454b55 ("merge-base: handle --fork-point without reflog", > 2016-10-12) introduced a fix for merge-base --fork-point without reflog > and a test. While that test is fine, it did not update expected nor actual > output and tested that of the previous test instead. Oops. The use of the existing "expect3" was intentional (the idea being that we are repeating the identical step from the previous test with the slight tweak of not having a reflog). But obviously failing to write to "actual" at all was a mistake. That said, I'm OK with reiterating the expected output. -Peff