From: Brandon Williams <bmwill@google.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] clang-format: adjust line break penalties
Date: Fri, 29 Sep 2017 12:50:00 -0700 [thread overview]
Message-ID: <20170929195000.GE177031@google.com> (raw)
In-Reply-To: <20170929184032.GK19555@aiede.mtv.corp.google.com>
On 09/29, Jonathan Nieder wrote:
> Hi Dscho,
>
> Johannes Schindelin wrote:
>
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> > .clang-format | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
>
> Well executed and well explained. Thank you.
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> Going forward, is there an easy way to preview the effect of this kind
> of change (e.g., to run "make style" on the entire codebase so as to be
> able to compare the result with two different versions of
> .clang-format)?
>
> Thanks,
> Jonathan
I don't think there's an easy way to do this yet (I'm sure we can make
one) though the biggest barrier to that is that most of the code base
probably isn't consistent with the current .clang-format.
I also took a look at the patch and agree with all your points. I'm
sure we'll still have to do some tweaking of these parameters but I'll
start using this locally and see if I find any problems.
--
Brandon Williams
next prev parent reply other threads:[~2017-09-29 19:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 18:26 [PATCH] clang-format: adjust line break penalties Johannes Schindelin
2017-09-29 18:40 ` Jonathan Nieder
2017-09-29 19:50 ` Brandon Williams [this message]
2017-09-29 22:39 ` Stephan Beyer
2017-09-29 22:45 ` Jonathan Nieder
2017-09-30 21:37 ` [PATCH] Add a comment to .clang-format about the meaning of the file Stephan Beyer
2017-10-01 2:45 ` Junio C Hamano
2017-10-01 15:44 ` [PATCH v2] " Stephan Beyer
2017-10-01 20:30 ` Junio C Hamano
2017-10-01 21:29 ` Stephan Beyer
2017-10-01 23:37 ` [PATCH v3] clang-format: add a comment about the meaning/status of the Junio C Hamano
2017-10-02 17:16 ` Stephan Beyer
2017-10-02 17:21 ` Brandon Williams
2017-10-03 1:08 ` Ramsay Jones
2017-10-01 2:40 ` [PATCH] clang-format: adjust line break penalties Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170929195000.GE177031@google.com \
--to=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).