From: Jonathan Nieder <jrnieder@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] submodule: spell out API of submodule_move_head
Date: Mon, 9 Oct 2017 15:22:24 -0700 [thread overview]
Message-ID: <20171009222224.GD19555@aiede.mtv.corp.google.com> (raw)
In-Reply-To: <20171009220615.27541-1-sbeller@google.com>
Stefan Beller wrote:
> This way users of this function do not need to read the implementation to
> know what it will do.
>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> submodule.c | 5 -----
> submodule.h | 18 ++++++++++++++++++
> 2 files changed, 18 insertions(+), 5 deletions(-)
Looks good (well, you'd expect me to think that :)). Thanks.
next prev parent reply other threads:[~2017-10-09 22:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 22:06 [PATCH] submodule: spell out API of submodule_move_head Stefan Beller
2017-10-09 22:22 ` Jonathan Nieder [this message]
2017-10-10 0:16 ` Junio C Hamano
2017-10-10 0:27 ` Jonathan Nieder
2017-10-10 0:42 ` Junio C Hamano
2017-10-10 0:55 ` Jonathan Nieder
2017-10-10 1:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009222224.GD19555@aiede.mtv.corp.google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox