From: Heiko Voigt <hvoigt@hvoigt.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
Stefan Beller <sbeller@google.com>,
git@vger.kernel.org
Subject: Re: [PATCH] status: do not get confused by submodules in excluded directories
Date: Tue, 24 Oct 2017 14:15:36 +0200 [thread overview]
Message-ID: <20171024121536.GA88363@book.hvoigt.net> (raw)
In-Reply-To: <xmqqo9oxkts6.fsf@gitster.mtv.corp.google.com>
On Tue, Oct 24, 2017 at 02:18:49PM +0900, Junio C Hamano wrote:
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>
> > We meticulously pass the `exclude` flag to the `treat_directory()`
> > function so that we can indicate that files in it are excluded rather
> > than untracked when recursing.
> >
> > But we did not yet treat submodules the same way.
>
> ... "because of that, we ended up showing <<what incorrect result in
> what situation>>" would be a nice thing to have here, so that it can
> be copied to the release notes for the bugfix.
Yes I agree that would be nice here. It was not immediately obvious that
this only applies when using both flags: -u and --ignored.
Seems to be a corner that not many people are using. At first I thought
a plain 'git status' would show that behavior...
> How far back a release do we want to make this fix applicable? It
> seems that it applies cleanly to maint-2.13 without breaking from my
> quick test, so that is probably where I'll queue this, even though
> we may no longer issue further maintenance releases on that track.
>
> Any comment from submodule folks?
>
> Sorry that I didn't notice this was left unattended by anybody til
> now. Will queue while waiting for those who are into submodules to
> respond.
Looks good to me.
Cheers Heiko
next prev parent reply other threads:[~2017-10-24 12:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 13:10 [PATCH] status: do not get confused by submodules in excluded directories Johannes Schindelin
2017-10-24 5:18 ` Junio C Hamano
2017-10-24 12:15 ` Heiko Voigt [this message]
2017-10-24 15:34 ` Stefan Beller
2017-10-25 1:28 ` Junio C Hamano
2017-10-25 14:04 ` Heiko Voigt
2017-10-25 20:39 ` Johannes Schindelin
2017-10-24 8:20 ` Kevin Daudt
2017-10-25 13:26 ` Johannes Schindelin
2017-10-25 20:40 ` [PATCH v2 0/1] Do not handle submodules in excluded directories as untracked Johannes Schindelin
2017-10-25 20:40 ` [PATCH v2 1/1] status: do not get confused by submodules in excluded directories Johannes Schindelin
2017-10-26 2:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024121536.GA88363@book.hvoigt.net \
--to=hvoigt@hvoigt.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).