From: Adam Dinwoodie <adam@dinwoodie.org>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCH v2] doc/SubmittingPatches: correct subject guidance
Date: Thu, 9 Nov 2017 12:47:14 +0000 [thread overview]
Message-ID: <20171109124714.GH20681@dinwoodie.org> (raw)
In-Reply-To: <CAPig+cRaygrQ9_J1UHr_rynPsUn2J0--RHRvP2mFQbVQhWEm-Q@mail.gmail.com>
On Wednesday 08 November 2017 at 09:10 am -0500, Eric Sunshine wrote:
> On Wed, Nov 8, 2017 at 8:47 AM, Adam Dinwoodie <adam@dinwoodie.org> wrote:
> > +e-mail discussions. Use of markers in addition to PATCH within
> > +the brackets to describe the nature of the patch is also
> > +encouraged. E.g. [RFC PATCH] is often used when the patch is not
> > +ready to be applied but it is for discussion, and can be added
> > +with the `--rfc` argument to `git format-patch` or `git
> > +send-email`, while [PATCH v2], [PATCH v3] etc. are often seen
>
> It has become a bit of a run-on sentence, but aside from that and the
> unnecessary extra whitespace between "etc." and "are", it looks good
> to me.
Both good points, thank you! I suspect the extra whitespace was a
result of Vim being "helpful" when reflowing the text.
I'll re-spin now with fixed whitespace and breaking up the sentence a
bit.
next prev parent reply other threads:[~2017-11-09 12:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 13:16 [PATCH] doc/SubmittingPatches: correct subject guidance Adam Dinwoodie
2017-11-08 13:47 ` [PATCH v2] " Adam Dinwoodie
2017-11-08 14:10 ` Eric Sunshine
2017-11-09 12:47 ` Adam Dinwoodie [this message]
2017-11-09 13:08 ` [PATCH v3] " Adam Dinwoodie
2017-11-09 16:10 ` Eric Sunshine
2017-11-10 15:02 ` [PATCH v4] " Adam Dinwoodie
2017-11-10 17:52 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109124714.GH20681@dinwoodie.org \
--to=adam@dinwoodie.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=josh@joshtriplett.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).