From: Adam Dinwoodie <adam@dinwoodie.org>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Phillip Wood <phillip.wood@dunelm.org.uk>,
Stefan Beller <sbeller@google.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: t3512 & t3513 'unexpected passes'
Date: Tue, 21 Nov 2017 10:44:04 +0000 [thread overview]
Message-ID: <20171121104404.GN20681@dinwoodie.org> (raw)
In-Reply-To: <73f0fb1e-5b55-1049-7706-652f1f9deaed@ramsayjones.plus.com>
On Monday 20 November 2017 at 08:16 pm +0000, Ramsay Jones wrote:
> For several days, I have been staring at some 'unexpected passes' in
> the t3512-cherry-pick-submodule.sh and t3513-revert-submodule.sh test
> files (tests #11-13 in both cases).
>
> I finally found time tonight to 'git bisect' the 'problem', and found
> that bisect fingered commit b5a812b298 ("sequencer: try to commit without
> forking 'git commit'", 17-11-2017).
>
> During the bisection I stumbled across (several times) the following
> compilation error:
>
> CC sequencer.o
> sequencer.c: In function ‘do_commit’:
> sequencer.c:1142:9: error: void value not ignored as it ought to be
> res = print_commit_summary(NULL, &oid,
> ^
> Makefile:2105: recipe for target 'sequencer.o' failed
> make: *** [sequencer.o] Error 1
>
> which I 'fixed' like so: s/res = //
>
> So, given that the 'fingered' commit didn't immediately seem to be
> related to the problem, along with the above errors, this may well
> not be the culprit.
I've seen the same unexpected passes, and had just completed the same
bisect run myself, although I fixed the build failure by cherry-picking
82921316a ("SQUASH???", 2017-11-18) onto commits that wouldn't build,
given that commit seems to exist entirely to fix that build breakage. I
think that adds more weight to b5a812b29 being the culprit for these
unexpected passes.
It's definitely the case that these unexpected passes exist at 8e4ff0ae1
("Merge branch 'pw/sequencer-in-process-commit' into pu", 2017-11-21)
and do not exist at its immediate left-hand parent, e017a4ccc ("Merge
branch 'jn/ssh-wrappers' into jch", 2017-11-21), which means it's
clearly _something_ in the branch merged at 8e4ff0ae1.
next prev parent reply other threads:[~2017-11-21 10:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 20:16 t3512 & t3513 'unexpected passes' Ramsay Jones
2017-11-21 10:44 ` Adam Dinwoodie [this message]
2017-11-21 18:19 ` Phillip Wood
2017-11-22 1:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121104404.GN20681@dinwoodie.org \
--to=adam@dinwoodie.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=ramsay@ramsayjones.plus.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).