From: Jeff King <peff@peff.net>
To: Derrick Stolee <dstolee@microsoft.com>
Cc: git@vger.kernel.org, stolee@gmail.com, git@jeffhostetler.com
Subject: Re: [PATCH v2] sha1_file: use strbuf_add() instead of strbuf_addf()
Date: Mon, 4 Dec 2017 11:56:53 -0500 [thread overview]
Message-ID: <20171204165652.GA12701@sigill.intra.peff.net> (raw)
In-Reply-To: <20171204140603.180079-1-dstolee@microsoft.com>
On Mon, Dec 04, 2017 at 09:06:03AM -0500, Derrick Stolee wrote:
> Thanks for the feedback on v1. This version fixes the cruft_cb
> bug and streamlines the strlen(). I would include an inter-diff
> but it was the same size as the patch.
Thanks, this version looks good to me. One procedural nit:
> Thanks,
> -Stolee
>
> ---
When you put your cover letter first, you need to use "scissors" like:
-- >8 --
to separate it from the commit message. Using three-dashes means "git
am" will include your cover letter as the commit message, and omit your
real commit message entirely.
-Peff
next prev parent reply other threads:[~2017-12-04 16:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 17:49 [PATCH] sha1_file: use strbuf_add() instead of strbuf_addf() Derrick Stolee
2017-12-01 18:22 ` Jeff King
2017-12-01 19:50 ` Derrick Stolee
2017-12-01 22:39 ` Jeff King
2017-12-04 14:06 ` [PATCH v2] " Derrick Stolee
2017-12-04 16:56 ` Jeff King [this message]
2017-12-04 17:12 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204165652.GA12701@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=dstolee@microsoft.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).