From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id C786420954 for ; Mon, 4 Dec 2017 22:09:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752903AbdLDWJL (ORCPT ); Mon, 4 Dec 2017 17:09:11 -0500 Received: from cloud.peff.net ([104.130.231.41]:48008 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752464AbdLDWJL (ORCPT ); Mon, 4 Dec 2017 17:09:11 -0500 Received: (qmail 11186 invoked by uid 109); 4 Dec 2017 22:09:11 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Mon, 04 Dec 2017 22:09:11 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 27560 invoked by uid 111); 4 Dec 2017 22:09:31 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with ESMTPA; Mon, 04 Dec 2017 17:09:31 -0500 Authentication-Results: peff.net; auth=pass (cram-md5) smtp.auth=relayok Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Mon, 04 Dec 2017 17:09:09 -0500 Date: Mon, 4 Dec 2017 17:09:09 -0500 From: Jeff King To: Lars Schneider Cc: Kaartic Sivaraam , lars.schneider@autodesk.com, git@vger.kernel.org, gitster@pobox.com, sbeller@google.com, sunshine@sunshineco.com, sandals@crustytoothpaste.net Subject: Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input Message-ID: <20171204220908.GA8184@sigill.intra.peff.net> References: <20171129143752.60553-3-lars.schneider@autodesk.com> <20171130205137.GC3313@sigill.intra.peff.net> <20171201182924.GB27688@sigill.intra.peff.net> <20171204172623.GD13332@sigill.intra.peff.net> <07CF6EAE-815E-4846-887D-560F2459E69D@gmail.com> <20171204214221.GB21552@sigill.intra.peff.net> <787AD800-7169-4B83-A1AD-171A15D103B9@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <787AD800-7169-4B83-A1AD-171A15D103B9@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Dec 04, 2017 at 10:54:40PM +0100, Lars Schneider wrote: > > Better, IMHO, though I still think literally saying: > > > > hint: Waiting for your editor to exit... > > > > is the most accurate, which I think makes it clear that you must _exit_ > > your editor, not just save and close the file. > > I think "exit" would be confusing because most graphical editors (Sublime, > Textmate, Notepad++, ...) can open multiple files and do not need to exit. > The requirement is indeed save and close the file. > > How about: > > hint: Waiting for your editor to close the file... > > I generally like that as this is technical correct from all angles. > My only nit would be that "the file" is a bit imprecise... but > that's probably no problem. OK, that makes sense. There are two definitions of "exit" here. We care about the process exiting, but of course the editor may present a concept of "exiting" to the user that is different. I know emacsclient behaves that way (the client process exits when the buffer is closed, even though the rest of emacs may still be running), but I didn't realize other editors did so. I know atom doesn't, but then it also exits immediately, making it inappropriate for $GIT_EDITOR in the first place. -Peff