From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Olga Telezhnaya <olyatelezhnaya@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH Outreachy 1/2] format: create pretty.h file
Date: Sun, 10 Dec 2017 09:53:54 -0500 [thread overview]
Message-ID: <20171210145354.GA20367@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqq7etx9kzq.fsf@gitster.mtv.corp.google.com>
On Fri, Dec 08, 2017 at 09:40:09AM -0800, Junio C Hamano wrote:
> I see you've "standardized" to drop "extern" from the declarations
> in the header; I have an impression that our preference however is
> to go in the other direction.
Can we revisit that?
I haven't see any compelling reason to include the "extern" in a
declaration. And all things being equal, I'd prefer the thing that makes
the source code shorter, and is one less thing for authors to remember
to do.
-Peff
next prev parent reply other threads:[~2017-12-10 14:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 13:21 [PATCH Outreachy 1/2] format: create pretty.h file Olga Telezhnaya
2017-12-08 13:21 ` [PATCH Outreachy 2/2] format: create docs for pretty.h Olga Telezhnaya
2017-12-08 19:26 ` Eric Sunshine
2017-12-08 17:40 ` [PATCH Outreachy 1/2] format: create pretty.h file Junio C Hamano
2017-12-10 14:53 ` Jeff King [this message]
2017-12-10 22:36 ` Junio C Hamano
2017-12-11 9:58 ` Оля Тележная
2017-12-11 20:43 ` Junio C Hamano
2017-12-08 18:11 ` Eric Sunshine
2017-12-08 20:37 ` Junio C Hamano
2017-12-09 7:48 ` Оля Тележная
2017-12-12 8:55 ` [PATCH Outreachy v2 " Olga Telezhnaya
2017-12-12 8:55 ` [PATCH Outreachy v2 2/2] format: create docs for pretty.h Olga Telezhnaya
2017-12-12 22:12 ` [PATCH Outreachy v2 1/2] format: create pretty.h file Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171210145354.GA20367@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=olyatelezhnaya@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox