From: Jeff King <peff@peff.net>
To: Wei Shuyu <wsy@dogben.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] http: support CURLPROXY_HTTPS
Date: Wed, 20 Dec 2017 06:41:31 -0500 [thread overview]
Message-ID: <20171220114131.GA16643@sigill.intra.peff.net> (raw)
In-Reply-To: <a572179929e666e4e598930ec774c4db@dogben.com>
On Wed, Dec 20, 2017 at 10:22:06AM +0800, Wei Shuyu wrote:
> On 2017-12-20 04:59, Jonathan Nieder wrote:
>
> > Thanks for writing this. Can you give an example of how I'd use it
> > (ideally in the form of a test in t/ so we avoid this functionality
> > regressing, but if that's not straightforward then an example for the
> > commit message is fine as well)?
>
> Hi Jonathan,
> Its usage is the same as other protocols. Just set http.proxy or
> http_proxy/https_proxy
> environment to https://url.
>
> To use apache server as a proxy, just add `ProxyRequests On` to an https
> site.
Unfortunately I don't think we have any proxy tests at all in our test
suite right now. The sticking point is that we need an actual proxy to
test against. :)
If it really is as simple as "ProxyRequests On", then we might be able
to convince the existing apache process we run to proxy requests to
itself (perhaps on a secondary port?).
-Peff
prev parent reply other threads:[~2017-12-20 11:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 17:24 [PATCH] http: support CURLPROXY_HTTPS Wei Shuyu
2017-12-19 20:59 ` Jonathan Nieder
2017-12-19 21:38 ` Junio C Hamano
2017-12-19 21:50 ` Jonathan Nieder
[not found] ` <a572179929e666e4e598930ec774c4db@dogben.com>
2017-12-20 2:30 ` Wei Shuyu
2017-12-20 11:41 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220114131.GA16643@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=wsy@dogben.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).