From: Jeff King <peff@peff.net>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Ernesto Alfonso <erjoalgo@gmail.com>, git@vger.kernel.org
Subject: Re: possible completion bug with --set-upstream-to=
Date: Sat, 30 Dec 2017 09:51:44 -0500 [thread overview]
Message-ID: <20171230145143.GB29252@sigill.intra.peff.net> (raw)
In-Reply-To: <20171230082806.6303-1-szeder.dev@gmail.com>
On Sat, Dec 30, 2017 at 09:28:06AM +0100, SZEDER Gábor wrote:
> I couldn't reproduce the wrong behavior you saw using v2.1.4 in a
> regular setup.
>
> However, I could reproduce it after I removed the '=' character from
> the set of characters in $COMP_WORDBREAKS, but then all completions
> after an '--option=' are affected, e.g. 'pulseaudio --daemonize=t<TAB>
> becomes 'pulseaudio true', too.
I can reproduce here on my Debian unstable system.
> Could you tell us the content of your $COMP_WORDBREAKS using the
> output of the following command (to make the included space, tab and
> newline visible):
>
> printf "$COMP_WORDBREAKS" |tr ' \t\n' STN ; echo
>
> If it's indeed the case that $COMP_WORDBREAKS is missing the '=', then
> you should add it back and check whether it fixed the issue. If it
> did fix it, then you should try to figure out how the '=' got removed
> from there. Perhaps you used a program that ships its own completion
> script whose developers changed $COMP_WORDBREAKS to their liking, not
> knowing about its effect on other completion scripts.
Looks like the system npm completion is the culprit:
$ grep COMP_WORDBREAKS /etc/bash_completion.d/*
/etc/bash_completion.d/npm:COMP_WORDBREAKS=${COMP_WORDBREAKS/=/}
/etc/bash_completion.d/npm:COMP_WORDBREAKS=${COMP_WORDBREAKS/@/}
/etc/bash_completion.d/npm:export COMP_WORDBREAKS
$ dpkg -S /etc/bash_completion.d/npm
npm: /etc/bash_completion.d/npm
Looks like there's already a bug filed:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=711810
Sadly there's even a patch which was taken upstream, but the debian
packaged version of npm is just woefully out of date.
-Peff
prev parent reply other threads:[~2017-12-30 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-30 0:26 possible completion bug with --set-upstream-to= Ernesto Alfonso
2017-12-30 8:28 ` SZEDER Gábor
2017-12-30 14:51 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171230145143.GB29252@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=erjoalgo@gmail.com \
--cc=git@vger.kernel.org \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).