From: Jeff King <peff@peff.net>
To: Todd Zullinger <tmz@pobox.com>
Cc: git@vger.kernel.org, Brandon Williams <bmwill@google.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] http: fix v1 protocol tests with apache httpd < 2.4
Date: Wed, 3 Jan 2018 00:56:47 -0500 [thread overview]
Message-ID: <20180103055646.GA25752@sigill.intra.peff.net> (raw)
In-Reply-To: <20171231023234.21215-1-tmz@pobox.com>
On Sat, Dec 30, 2017 at 09:32:34PM -0500, Todd Zullinger wrote:
> The apache config used by tests was updated to use the SetEnvIf
> directive to set the Git-Protocol header in 19113a26b6 ("http: tell
> server that the client understands v1", 2017-10-16).
>
> Setting the Git-Protocol header is restricted to httpd >= 2.4, but
> mod_setenvif and the SetEnvIf directive work with lower versions, at
> least as far back as 2.0, according to the httpd documentation:
>
> https://httpd.apache.org/docs/2.0/mod/mod_setenvif.html
>
> Drop the restriction. Tested with httpd 2.2 and 2.4.
Makes sense. I think the only way this could backfire is if somebody has
a funny build that doesn't include mod_setenvif at all. But I don't
think we can know that for sure without applying this and seeing if
anybody screams.
> I removed the version restriction entirely rather than adjust
> the version. I believe SetEnvIf works on httpd >= 2.0. I'm
> not sure if we aim to support anything less than httpd 2.0,
> but I'm betting not. If that's incorrect, I can add some
> IfVersion conditions.
IIRC, anything less than 2.0 is broken already. And it's not worth
changing that, given the age (and I think there were some pretty severe
hardships in making 1.3.x, but it's been a while).
-Peff
prev parent reply other threads:[~2018-01-03 5:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-31 2:32 [PATCH] http: fix v1 protocol tests with apache httpd < 2.4 Todd Zullinger
2018-01-03 0:21 ` Brandon Williams
2018-01-03 0:39 ` Todd Zullinger
2018-01-03 6:17 ` Jeff King
2018-01-03 16:21 ` Todd Zullinger
2018-01-03 5:56 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103055646.GA25752@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).