git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Isaac Shabtay <isaac@shabtay.com>
Cc: git@vger.kernel.org
Subject: Re: Bug report: git clone with dest
Date: Wed, 3 Jan 2018 17:28:21 -0500	[thread overview]
Message-ID: <20180103222821.GA32287@sigill.intra.peff.net> (raw)
In-Reply-To: <CAK2k7nSsygwRj_Hhrz7-qXZ8UBB=O+deOeC2FFTkrGmWSUpKqA@mail.gmail.com>

On Wed, Jan 03, 2018 at 12:59:48PM -0800, Isaac Shabtay wrote:

> Target directory is deleted on clone failures.
> 
> Steps to reproduce, for example on Windows:
> 
> cd /d %TEMP%
> mkdir dest
> git clone https://some-fake-url/whatever-makes-git-clone-fail dest
> 
> Of course, the clone will fail as it should. But looks like the Git
> client also ends up deleting the "dest" directory.

Interesting. AFAICT Git has behaved this way for almost 9 years, and now
we have two reports in two days. Serendipity, or did something else
change? :)

Anyway, you might be interested in the patch series I posted yesterday:

  https://public-inbox.org/git/20180102210753.GA10430@sigill.intra.peff.net/

-Peff

  reply	other threads:[~2018-01-03 22:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-03 20:59 Bug report: git clone with dest Isaac Shabtay
2018-01-03 22:28 ` Jeff King [this message]
2018-01-03 22:44   ` Isaac Shabtay
2018-01-04 23:20     ` Johannes Schindelin
2018-01-05  5:11       ` Isaac Shabtay
2018-01-05 10:33         ` Johannes Schindelin
2018-01-05 18:55           ` Isaac Shabtay
2018-01-05 20:22             ` Johannes Schindelin
2018-01-05 20:38               ` Junio C Hamano
2018-01-05 20:44               ` Jeff King
2018-01-05 21:39                 ` Johannes Schindelin
     [not found]   ` <CAK2k7nQcY+QQBfda6CHM8tFo3i4XX2tXxHKv73t6SJ4rRvWo1w@mail.gmail.com>
2018-01-04  4:01     ` Jeff King
2018-01-05 19:53       ` Junio C Hamano
2018-01-05 19:57         ` Jeff King
2018-01-05 20:45           ` Junio C Hamano
2018-01-05 20:52             ` Jeff King
2018-01-05 22:37               ` Junio C Hamano
2018-01-06  4:43                 ` Jeff King
2018-01-05 21:06         ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180103222821.GA32287@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=isaac@shabtay.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).