From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Derrick Stolee <stolee@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Jeff Hostetler <git@jeffhostetler.com>,
Ben Peart <peartben@gmail.com>,
git@vger.kernel.org, Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v4 0/4] Add --no-ahead-behind to status
Date: Thu, 11 Jan 2018 04:39:43 -0500 [thread overview]
Message-ID: <20180111093943.GC9190@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqfu7d1n2l.fsf@gitster.mtv.corp.google.com>
On Wed, Jan 10, 2018 at 12:22:10PM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > To be clear, which approach are we talking about? I think there are
> > three options:
> >
> > 1. The user tells us not to bother computing real ahead/behind values.
> > We always say "same" or "not the same".
> >
> > 2. The user tells us not to bother computing ahead/behind values
> > with more effort than N. After traversing N commits without getting
> > an answer, we say "same" or "not the same". But we may sometimes
> > give a real answer if we found it within N.
> >
> > 3. The user tells us not to spend more effort than N. After traversing
> > N commits we try to make some partial statement based on
> > generations (or commit timestamps as a proxy for them).
> >
> > I agree that (3) is probably not going to be useful enough in the
> > general case to merit the implementation effort and confusion. But is
> > there anything wrong with (2)?
>
> I agree (3) would not be all that interesting. Offhand I do not see
> a problem with (2). I think with "real" in your "sometimes give a
> real answer" you meant to say that we limit our answers to just one
> three ("same", "not the same", "ahead/behind by exactly N/M") and I
> think it is a good choice that is easy to explain.
Yes, exactly. That's a better way of saying it.
-Peff
next prev parent reply other threads:[~2018-01-11 9:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 15:48 [PATCH v4 0/4] Add --no-ahead-behind to status Jeff Hostetler
2018-01-08 15:48 ` [PATCH v4 1/4] stat_tracking_info: return +1 when branches not equal Jeff Hostetler
2018-01-08 15:48 ` [PATCH v4 2/4] status: add --[no-]ahead-behind to status and commit for V2 format Jeff Hostetler
2018-01-08 15:48 ` [PATCH v4 3/4] status: update short status to respect --no-ahead-behind Jeff Hostetler
2018-01-08 15:48 ` [PATCH v4 4/4] status: support --no-ahead-behind in long format Jeff Hostetler
2018-01-08 19:49 ` [PATCH v4 0/4] Add --no-ahead-behind to status Ben Peart
2018-01-08 20:04 ` Jeff Hostetler
2018-01-09 7:20 ` Jeff King
2018-01-09 13:15 ` Johannes Schindelin
2018-01-09 14:29 ` Derrick Stolee
2018-01-09 14:56 ` Jeff Hostetler
2018-01-09 16:48 ` Johannes Schindelin
2018-01-10 7:47 ` Jeff King
2018-01-10 20:22 ` Junio C Hamano
2018-01-11 9:39 ` Jeff King [this message]
2018-01-10 7:41 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111093943.GC9190@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=peartben@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).