From: Jeff King <peff@peff.net>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH v2 0/2] wrap format-patch diffstats around 72 columns
Date: Sat, 27 Jan 2018 11:48:44 -0500 [thread overview]
Message-ID: <20180127164843.GB23478@sigill.intra.peff.net> (raw)
In-Reply-To: <20180125115927.16196-1-pclouds@gmail.com>
On Thu, Jan 25, 2018 at 06:59:25PM +0700, Nguyễn Thái Ngọc Duy wrote:
> Like v1, these changes keep diffstat generated by format-patch in 72
> columns. This constant is already used in the code, so it's a bit
> better than my random "70 or 75" value.
>
> Granted these hard coded values (both 80 and 72) are not really nice.
> But I would wait for somebody to say "I need or want this" before I
> add code to make the default configurable.
>
> Nguyễn Thái Ngọc Duy (2):
> format-patch: keep cover-letter diffstat wrapped in 72 columns
> format-patch: reduce patch diffstat width to 72
This looks OK to me. There was one head-scratcher in the second patch
which I mentioned, but I think it's probably OK.
I also notice that we have no tests for diffstat on a cover letter,
which might be worth addressing.
-Peff
next prev parent reply other threads:[~2018-01-27 16:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 12:31 [PATCH] format-patch: set diffstat width to 70 instead of default 80 Nguyễn Thái Ngọc Duy
2018-01-22 23:13 ` Junio C Hamano
2018-01-22 23:52 ` Jeff King
2018-01-23 0:10 ` Ævar Arnfjörð Bjarmason
2018-01-23 0:12 ` Jeff King
2018-01-23 2:42 ` Duy Nguyen
2018-01-23 0:08 ` Ævar Arnfjörð Bjarmason
2018-01-25 11:59 ` [PATCH v2 0/2] wrap format-patch diffstats around 72 columns Nguyễn Thái Ngọc Duy
2018-01-25 11:59 ` [PATCH v2 1/2] format-patch: keep cover-letter diffstat wrapped in " Nguyễn Thái Ngọc Duy
2018-01-25 11:59 ` [PATCH v2 2/2] format-patch: reduce patch diffstat width to 72 Nguyễn Thái Ngọc Duy
2018-01-27 16:47 ` Jeff King
2018-01-30 10:22 ` Duy Nguyen
2018-01-27 16:48 ` Jeff King [this message]
2018-02-01 12:47 ` [PATCH v3 0/2] wrap format-patch diffstats around 72 columns Nguyễn Thái Ngọc Duy
2018-02-01 12:47 ` [PATCH v3 1/2] format-patch: keep cover-letter diffstat wrapped in " Nguyễn Thái Ngọc Duy
2018-02-01 12:47 ` [PATCH v3 2/2] format-patch: reduce patch diffstat width to 72 Nguyễn Thái Ngọc Duy
2018-02-02 18:42 ` [PATCH v3 0/2] wrap format-patch diffstats around 72 columns Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180127164843.GB23478@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).