From: Jeff King <peff@peff.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Elijah Newren <newren@gmail.com>,
Stefan Beller <sbeller@google.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: BUG: fetch in certain repo always gives "did not send all necessary objects"
Date: Wed, 7 Feb 2018 08:23:05 -0500 [thread overview]
Message-ID: <20180207132304.GC16018@sigill.intra.peff.net> (raw)
In-Reply-To: <CACsJy8CUgmyw6Ug6wQEFaj9Ze45mZfRoE4J16zVv5usT791Kmw@mail.gmail.com>
On Wed, Feb 07, 2018 at 06:08:40PM +0700, Duy Nguyen wrote:
> > And/or ideas of what steps could cause corruption so I can send out a
> > PSA to help users avoid it?
>
> There is another thing we could do. One bad HEAD should not abort the
> entire operation (at least if it's not the current worktree's HEAD).
> We could still give a warning and move on, or don't warn at all and
> let "git worktree prune" collect it (which I see from your message
> that it also fails to do).
Whether that's safe or not depends very much on what the caller intends
to do with the ref. Skipping broken refs in "git prune" is a bad idea,
for instance.
-Peff
next prev parent reply other threads:[~2018-02-07 13:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 23:04 BUG: fetch in certain repo always gives "did not send all necessary objects" Elijah Newren
2018-02-06 23:20 ` Stefan Beller
2018-02-07 0:00 ` Elijah Newren
2018-02-07 11:08 ` Duy Nguyen
2018-02-07 13:23 ` Jeff King [this message]
2018-02-07 18:12 ` Elijah Newren
2018-02-07 13:21 ` Jeff King
2018-02-07 13:25 ` Jeff King
2018-02-07 17:25 ` Elijah Newren
2018-02-07 18:17 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207132304.GC16018@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).