From: Elijah Newren <newren@gmail.com>
To: git@vger.kernel.org
Cc: pclouds@gmail.com, peff@peff.net, Elijah Newren <newren@gmail.com>
Subject: [RFC PATCH 0/3] Make fsck check other worktree HEADs
Date: Fri, 9 Feb 2018 15:13:27 -0800 [thread overview]
Message-ID: <20180209231330.4457-1-newren@gmail.com> (raw)
This patchset adds checking of other worktree HEADs to fsck.
The reason I've marked this RFC is that I'm worried my incidental
reliance on "worktrees/$WORKTREE/HEAD" resolving as a ref (in patch 3)
might raise some flags for others. In particular, in [1] Peff said
that this refname resolves right now mostly by accident and will
probably stop working in the future. However, I feel that since fsck
checks the storage format as well as contents, it seems natural that a
change of storage model would result in the fsck code changing and
thus that I'm not locking in any particular ref format long term with
these changes. But I want to flag this issue for discussion.
[1] https://public-inbox.org/git/20180207181706.GA4227@sigill.intra.peff.net/
Elijah Newren (3):
fsck: Move fsck_head_link() to get_default_heads() to avoid some
globals
t1450-fsck: Add tests for HEAD of other worktrees
fsck: Check HEAD of other worktrees as well
builtin/fsck.c | 73 ++++++++++++++++++++++++++++++++++++++++++++-------------
t/t1450-fsck.sh | 27 +++++++++++++++++++++
2 files changed, 84 insertions(+), 16 deletions(-)
--
2.16.1.75.gc01c8fdd7d
next reply other threads:[~2018-02-09 23:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 23:13 Elijah Newren [this message]
2018-02-09 23:13 ` [RFC PATCH 1/3] fsck: Move fsck_head_link() to get_default_heads() to avoid some globals Elijah Newren
2018-02-09 23:13 ` [RFC PATCH 2/3] t1450-fsck: Add tests for HEAD of other worktrees Elijah Newren
2018-02-09 23:13 ` [RFC PATCH 3/3] fsck: Check HEAD of other worktrees as well Elijah Newren
2018-02-10 9:59 ` Duy Nguyen
2018-02-10 12:34 ` Jeff King
2018-02-10 20:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180209231330.4457-1-newren@gmail.com \
--to=newren@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).