From: Brandon Williams <bmwill@google.com>
To: Rasmus Villemoes <rv@rasmusvillemoes.dk>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/3] a few grep patches
Date: Thu, 15 Feb 2018 14:02:12 -0800 [thread overview]
Message-ID: <20180215220212.GA123347@google.com> (raw)
In-Reply-To: <20180215215615.21208-1-rv@rasmusvillemoes.dk>
On 02/15, Rasmus Villemoes wrote:
> I believe the first two should be ok, but I'm not sure what I myself
> think of the third one. Perhaps the saving is not worth the
> complexity, but it does annoy my optimization nerve to see all the
> unnecessary duplicated work being done.
I agree, the first two seem like good changes to me though I don't know
if i like the complexity that the third introduces.
>
> Rasmus Villemoes (3):
> grep: move grep_source_init outside critical section
> grep: simplify grep_oid and grep_file
> grep: avoid one strdup() per file
>
> builtin/grep.c | 25 ++++++++++++-------------
> grep.c | 8 ++++++--
> 2 files changed, 18 insertions(+), 15 deletions(-)
>
> --
> 2.15.1
>
--
Brandon Williams
next prev parent reply other threads:[~2018-02-15 22:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 21:56 [PATCH 0/3] a few grep patches Rasmus Villemoes
2018-02-15 21:56 ` [PATCH 1/3] grep: move grep_source_init outside critical section Rasmus Villemoes
2018-02-15 22:17 ` Jeff King
2018-02-16 19:24 ` Junio C Hamano
2018-02-15 21:56 ` [PATCH 2/3] grep: simplify grep_oid and grep_file Rasmus Villemoes
2018-02-15 21:56 ` [PATCH 3/3] grep: avoid one strdup() per file Rasmus Villemoes
2018-02-15 22:18 ` Jeff King
2018-02-15 22:02 ` Brandon Williams [this message]
2018-02-23 14:47 ` [PATCH v2 0/2] two small grep patches Rasmus Villemoes
2018-02-23 14:47 ` [PATCH v2 1/2] grep: move grep_source_init outside critical section Rasmus Villemoes
2018-02-23 14:47 ` [PATCH v2 2/2] grep: simplify grep_oid and grep_file Rasmus Villemoes
2018-02-23 18:01 ` [PATCH v2 0/2] two small grep patches Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215220212.GA123347@google.com \
--to=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=rv@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).