From: Brandon Williams <bmwill@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Feb 2018, #03; Wed, 21)
Date: Wed, 21 Feb 2018 16:56:40 -0800 [thread overview]
Message-ID: <20180222005640.GI127348@google.com> (raw)
In-Reply-To: <xmqq1shdyidz.fsf@gitster-ct.c.googlers.com>
On 02/21, Junio C Hamano wrote:
> * bw/c-plus-plus (2018-02-14) 38 commits
> - fixup! diff: rename 'this' variables
> - replace: rename 'new' variables
> - trailer: rename 'template' variables
> - tempfile: rename 'template' variables
> - wrapper: rename 'template' variables
> - environment: rename 'namespace' variables
> - diff: rename 'template' variables
> - environment: rename 'template' variables
> - init-db: rename 'template' variables
> - unpack-trees: rename 'new' variables
> - trailer: rename 'new' variables
> - submodule: rename 'new' variables
> - split-index: rename 'new' variables
> - remote: rename 'new' variables
> - ref-filter: rename 'new' variables
> - read-cache: rename 'new' variables
> - line-log: rename 'new' variables
> - imap-send: rename 'new' variables
> - http: rename 'new' variables
> - entry: rename 'new' variables
> - diffcore-delta: rename 'new' variables
> - diff: rename 'new' variables
> - diff-lib: rename 'new' variable
> - commit: rename 'new' variables
> - combine-diff: rename 'new' variables
> - remote: rename 'new' variables
> - reflog: rename 'new' variables
> - pack-redundant: rename 'new' variables
> - help: rename 'new' variables
> - checkout: rename 'new' variables
> - apply: rename 'new' variables
> - apply: rename 'try' variables
> - diff: rename 'this' variables
> - rev-parse: rename 'this' variable
> - pack-objects: rename 'this' variables
> - blame: rename 'this' variables
> - object: rename function 'typename' to 'type_name'
> - object_info: change member name from 'typename' to 'type_name'
>
> Avoid using identifiers that clash with C++ keywords. Even though
> it is not a goal to compile Git with C++ compilers, changes like
> this help use of code analysis tools that targets C++ on our
> codebase.
>
> Is the 'fixup!' cleanly squashable to the problematic one, or does
> this series require another reroll to get it in a good enough shape?
Yeah the fixup patch looks good to me. I don't think there was anything
else that needed attention so it should be in good shape with the fixup
patch.
--
Brandon Williams
next prev parent reply other threads:[~2018-02-22 0:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 0:31 What's cooking in git.git (Feb 2018, #03; Wed, 21) Junio C Hamano
2018-02-22 0:56 ` Brandon Williams [this message]
2018-02-22 18:06 ` Junio C Hamano
2018-02-23 12:11 ` Johannes Schindelin
2018-02-23 19:03 ` Junio C Hamano
2018-02-26 23:23 ` Johannes Schindelin
2018-02-27 20:38 ` Junio C Hamano
2018-02-23 13:05 ` Phillip Wood
2018-02-23 21:09 ` Elijah Newren
2018-02-27 19:13 ` Junio C Hamano
2018-02-26 10:17 ` Duy Nguyen
2018-02-26 11:17 ` Eric Sunshine
2018-02-27 13:49 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222005640.GI127348@google.com \
--to=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).