git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Christian Couder <christian.couder@gmail.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>, git <git@vger.kernel.org>
Subject: Re: Running some tests with -x fails
Date: Wed, 14 Mar 2018 10:50:50 -0400	[thread overview]
Message-ID: <20180314145050.GA15531@sigill.intra.peff.net> (raw)
In-Reply-To: <CAP8UFD29eFPfiW2PjOr4evjB2X=yDWULOgUx2NRM83Mt0FDXUw@mail.gmail.com>

On Wed, Mar 14, 2018 at 03:30:30PM +0100, Christian Couder wrote:

> I don't know if this is well known already, but when when I run some
> tests using -x on master they consistently fail (while they
> consistently pass without -x).
> 
> For example:
> 
> ./t5500-fetch-pack.sh -x
> 
> gives: # failed 3 among 353 test(s)
> 
> ./t0008-ignores.sh -x
> 
> gives: # failed 208 among 394 test(s)
> 
> Are we interested in trying to fix those failures or are we ok with them?

This is known; the issue is tests that run shell functions or subshells
and capture their stderr (which then get polluted by "-x" output). You
can either:

  - run the tests with bash, which uses BASH_XTRACEFD to send output
    directly to the terminal (see TEST_SHELL_PATH in recent versions)

  - try 'next'; Gábor has done some work recently to clean up tests so
    that this works even with non-bash shells. See the sg/test-x and
    sg/cvs-tests-with-x topics.

-Peff

      reply	other threads:[~2018-03-14 14:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14 14:30 Running some tests with -x fails Christian Couder
2018-03-14 14:50 ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180314145050.GA15531@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).