From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>,
Yasushi SHOJI <yasushi.shoji@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings
Date: Sun, 25 Mar 2018 15:20:22 +0000 [thread overview]
Message-ID: <20180325152022.GD74743@genre.crustytoothpaste.net> (raw)
In-Reply-To: <9839073c-84ca-f00e-d0e1-801e521ef29e@web.de>
[-- Attachment #1: Type: text/plain, Size: 480 bytes --]
On Sun, Mar 25, 2018 at 12:57:36PM +0200, René Scharfe wrote:
> Patch generated with Coccinelle and contrib/coccinelle/object_id.cocci.
>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
> This is a belated follow-up to f0a6068a9f (bisect: debug: convert struct
> object to object_id).
This looks good to me.
--
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 867 bytes --]
next prev parent reply other threads:[~2018-03-25 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 10:57 [PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings René Scharfe
2018-03-25 15:20 ` brian m. carlson [this message]
2018-03-25 16:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180325152022.GD74743@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=yasushi.shoji@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).