From: Jeff King <peff@peff.net>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] test_must_be_empty: simplify file existence check
Date: Mon, 26 Mar 2018 08:48:48 -0400 [thread overview]
Message-ID: <20180326124847.GA21993@sigill.intra.peff.net> (raw)
In-Reply-To: <20180326115815.10180-1-szeder.dev@gmail.com>
On Mon, Mar 26, 2018 at 01:58:15PM +0200, SZEDER Gábor wrote:
> Commit ea3c87d0b7 (test_must_be_empty: make sure the file exists, not
> just empty, 2018-02-27) basically duplicated the 'test_path_is_file'
> helper function in 'test_must_be_empty'.
>
> Just call 'test_path_is_file' to avoid this code duplication.
This looks like an improvement to me.
I think you meant to reference 11395a3b4b16d9fc637ca2e41a6892ea2e6289ce,
though (I don't have ea3c87d0b7 at all).
-Peff
next prev parent reply other threads:[~2018-03-26 12:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 11:58 [PATCH] test_must_be_empty: simplify file existence check SZEDER Gábor
2018-03-26 12:48 ` Jeff King [this message]
2018-03-26 13:09 ` SZEDER Gábor
2018-03-26 13:11 ` [PATCH v2] " SZEDER Gábor
2018-03-28 0:10 ` Junio C Hamano
2018-03-28 5:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180326124847.GA21993@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).