From: Jeff King <peff@peff.net>
To: Derrick Stolee <stolee@gmail.com>
Cc: Michael Haggerty <mhagger@alum.mit.edu>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, ethomson@edwardthomson.com
Subject: Re: [RFC 0/1] Tolerate broken headers in `packed-refs` files
Date: Mon, 26 Mar 2018 10:33:40 -0400 [thread overview]
Message-ID: <20180326143340.GA23926@sigill.intra.peff.net> (raw)
In-Reply-To: <f8d0f3b6-69b3-ba42-c39c-551814caf335@gmail.com>
On Mon, Mar 26, 2018 at 09:08:04AM -0400, Derrick Stolee wrote:
> Since most heavily-used tools that didn't spawn Git processes use LibGit2 to
> interact with Git repos, I added Ed Thomson to CC to see if libgit2 could
> ever write these bad header comments.
Ed can probably answer more definitively, but I dug in the libgit2
history a little, and I think it has only ever generated correct
"pack-refs with:" lines.
Ditto for JGit, though there it blames down to 1a6964c82 (Initial JGit
contribution to eclipse.org, 2009-09-29). I didn't dig further into the
historical JGit repository, but I think that's probably far enough to
feel good about it.
-Peff
next prev parent reply other threads:[~2018-03-26 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 12:42 [RFC 0/1] Tolerate broken headers in `packed-refs` files Michael Haggerty
2018-03-26 12:42 ` [RFC 1/1] packed-backend: ignore broken headers Michael Haggerty
2018-03-26 13:08 ` [RFC 0/1] Tolerate broken headers in `packed-refs` files Derrick Stolee
2018-03-26 14:33 ` Jeff King [this message]
2018-03-26 14:33 ` Edward Thomson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180326143340.GA23926@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=ethomson@edwardthomson.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).