From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id A06711F404 for ; Fri, 6 Apr 2018 19:53:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751967AbeDFTxd (ORCPT ); Fri, 6 Apr 2018 15:53:33 -0400 Received: from cloud.peff.net ([104.130.231.41]:56332 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751344AbeDFTxd (ORCPT ); Fri, 6 Apr 2018 15:53:33 -0400 Received: (qmail 25528 invoked by uid 109); 6 Apr 2018 19:53:33 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Fri, 06 Apr 2018 19:53:33 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 29062 invoked by uid 111); 6 Apr 2018 19:54:34 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Fri, 06 Apr 2018 15:54:34 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Fri, 06 Apr 2018 15:53:31 -0400 Date: Fri, 6 Apr 2018 15:53:31 -0400 From: Jeff King To: Johannes Schindelin Cc: git@vger.kernel.org, Junio C Hamano Subject: Re: [PATCH] t5404: relax overzealous test Message-ID: <20180406195331.GC11450@sigill.intra.peff.net> References: <958ee6f006aba0c67c8e064d31206e3e68a1cc49.1523043053.git.johannes.schindelin@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <958ee6f006aba0c67c8e064d31206e3e68a1cc49.1523043053.git.johannes.schindelin@gmx.de> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Apr 06, 2018 at 09:31:22PM +0200, Johannes Schindelin wrote: > In 0b294c0abf0 (make deleting a missing ref more quiet, 2008-07-08), we > added a test to verify that deleting an already-deleted ref does not > show an error. Amazing that it took this long to come up. > Suppose, however, that you are a big fan of whales. Or even better: your > IT administrator has a whale of a time picking cute user names, e.g. > referring to you (due to your like of India Pale Ales) as "one of the > cuter rorquals" (see https://en.wikipedia.org/wiki/Rorqual to learn a > thing or two about rorquals) and hence your home directory becomes > /home/cuterrorqual. If you now run t5404, it fails! Why? Because the > test calls `git push origin :b3` which outputs: > > To /home/cuterrorqual/git/t/trash directory.t5404-tracking-branches/. > - [deleted] b3 This is from the same Dscho who complains about the length of some of my commit messages, right? ;P > This patch chooses instead to look for the prefix "error:" at the > beginning of the line, so that there can be no ambiguity that any catch > was indeed a message generated by Git's `error_builtin()` function. Yep, this seems obviously correct. Right now we do not localize the "error" string, but I wonder if this ought to use test_i18ngrep. With or without that change, the patch looks good to me. -Peff