From: Jeff King <peff@peff.net>
To: Jonathan Primrose <jprimros@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: FREAD_READS_DIRECTORIES test fails for the wrong reasons
Date: Fri, 6 Apr 2018 18:07:36 -0400 [thread overview]
Message-ID: <20180406220736.GH7870@sigill.intra.peff.net> (raw)
In-Reply-To: <8ed8491f-9410-c509-5ef7-77638aa74038@gmail.com>
On Fri, Apr 06, 2018 at 05:57:15PM -0400, Jonathan Primrose wrote:
> > Oops. This is due to my 3adf9fdecf (configure.ac: loosen
> > FREAD_READS_DIRECTORIES test program, 2017-06-14).
> >
> > Neither I nor the original tester noticed, because we're on Linux, which
> > needs that set.
>
> I'm also running Linux, but somehow I ended up needing to check
> config.log and saw the error. I don't remember why I had to check.
> (I've been fixing the problem locally for the last few releases,
> figuring someone else would notice. I also remove the 'rm configure'
> from the distclean target in Makefile, just in case I decide to
> rebuild later.)
I think you'll find that most of the developers don't actually use
autoconf themselves, so bugs tend to go unnoticed there for a while.
(The failure case for setting this flag accidentally is not bad, either;
it just incurs an extra fstat).
-Peff
prev parent reply other threads:[~2018-04-06 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 18:06 FREAD_READS_DIRECTORIES test fails for the wrong reasons Jonathan Primrose
2018-04-06 19:33 ` Jeff King
2018-04-06 21:57 ` Jonathan Primrose
2018-04-06 22:07 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180406220736.GH7870@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jprimros@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).