From: "Florian Gamböck" <mail@floga.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Szeder Gábor" <szeder.dev@gmail.com>
Subject: Re: [RFC PATCH 1/1] completion: load completion file for external subcommand
Date: Tue, 10 Apr 2018 11:37:49 +0200 [thread overview]
Message-ID: <20180410093749.GA8706@arbeitsviech> (raw)
In-Reply-To: <xmqq8t9w591b.fsf@gitster-ct.c.googlers.com>
On 2018-04-10 07:06, Junio C Hamano wrote:
> Florian Gamböck <mail@floga.de> writes:
>> Does my reasoning make sense?
>
> Not at all.
:-( That actually hurt a bit.
> But ...
>
>> I mean, the result will be exactly the same, we are clearly only
>> talking about readability here.
>
> ... I agree, and I also think the "readability" is not absolute
> anyway.
>
> FWIW, personally I'd find "if $completion_func does not yet exist and
> a way to dynload stuff exists, then use that way to load it from an
> external file" the most natural way to express what you are doing.
Then let's go with that. Maybe I am overthinking things here and
re-wording doesn't hurt.
I'll send a new patch version later this day, including the commit
message re-wording suggestion from Stefan.
Thank you for your feedback!
--
Regards
Florian
prev parent reply other threads:[~2018-04-10 9:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 18:26 [RFC PATCH 0/1] completion: Dynamic completion loading Florian Gamböck
2018-04-08 18:26 ` [RFC PATCH 1/1] completion: Load completion file for external subcommand Florian Gamböck
2018-04-08 18:29 ` Florian Gamböck
2018-04-09 18:26 ` Stefan Beller
2018-04-09 19:49 ` Florian Gamböck
2018-04-19 14:12 ` SZEDER Gábor
2018-04-08 18:26 ` [RFC PATCH 1/1] completion: load " Florian Gamböck
2018-04-08 22:59 ` Junio C Hamano
2018-04-09 7:29 ` Florian Gamböck
2018-04-09 9:36 ` Junio C Hamano
2018-04-09 13:36 ` Florian Gamböck
2018-04-09 22:06 ` Junio C Hamano
2018-04-10 9:37 ` Florian Gamböck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410093749.GA8706@arbeitsviech \
--to=mail@floga.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).