From: Thomas Gummerer <t.gummerer@gmail.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH v2 1/2] completion: stop showing 'save' for stash by default
Date: Sun, 22 Apr 2018 21:36:32 +0100 [thread overview]
Message-ID: <20180422203632.GA25294@hank> (raw)
In-Reply-To: <CACsJy8BByBCh_DuDu9otO4RLpCnQ+HY-vHi4EDC3_dNQHjM1dg@mail.gmail.com>
On 04/20, Duy Nguyen wrote:
> On Fri, Apr 20, 2018 at 1:25 AM, Thomas Gummerer <t.gummerer@gmail.com> wrote:
> > The 'save' subcommand in git stash has been deprecated in
> > fd2ebf14db ("stash: mark "git stash save" deprecated in the man page",
> > 2017-10-22).
> >
> > Stop showing it when the users enters 'git stash <tab>' or 'git stash
> > s<tab>'. Keep showing it however when the user enters 'git stash sa<tab>'
> > or any more characters of the 'save' subcommand.
>
> I don't think this is worth it. You only save two keystrokes for 've'
> and already waste one on <tab>.
I think the main reason for keeping the completion is not actually
saving keystrokes, but rather not giving the users the false
impression that we removed the command, or that something is wrong
with it, without properly warning them before. That was the main
reason given in [1] why the completion is useful even for short
commands such as 'rm'.
So while I had the same impression before re-reading that thread, I
think keeping the completion for 'git stash sa<tab>' is the right
thing to do, and we can remove it some time after we started warning
about 'git stash save' being deprecated.
[1]: <01020160a0004473-277c3d7c-4e3b-4c50-9d44-4a106f37f1d9-000000@eu-west-1.amazonses.com>
> --
> Duy
next prev parent reply other threads:[~2018-04-22 20:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 21:29 [PATCH 0/3] completion: improvements for git stash Thomas Gummerer
2018-04-17 21:29 ` [PATCH 1/3] completion: rename save_opts to default_opts for stash Thomas Gummerer
2018-04-17 21:29 ` [PATCH 2/3] completion: stop completing 'save' as stash subcommand Thomas Gummerer
2018-04-17 21:29 ` [PATCH 3/3] completion: make stash -p and alias for stash push -p Thomas Gummerer
2018-04-18 8:32 ` [PATCH 0/3] completion: improvements for git stash Junio C Hamano
2018-04-18 21:15 ` Thomas Gummerer
2018-04-19 23:25 ` [PATCH v2 0/2] " Thomas Gummerer
2018-04-19 23:25 ` [PATCH v2 1/2] completion: stop showing 'save' for stash by default Thomas Gummerer
2018-04-20 5:17 ` Duy Nguyen
2018-04-22 20:36 ` Thomas Gummerer [this message]
2018-04-19 23:25 ` [PATCH v2 2/2] completion: make stash -p and alias for stash push -p Thomas Gummerer
2018-04-20 1:38 ` [PATCH v2 0/2] completion: improvements for git stash Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180422203632.GA25294@hank \
--to=t.gummerer@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).