From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Shulhan <ms@kilabit.info>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
"Martin Ågren" <martin.agren@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [bug] Multiline value should error if the next line is section
Date: Mon, 7 May 2018 01:25:14 +0200 [thread overview]
Message-ID: <20180506232514.3065-1-szeder.dev@gmail.com> (raw)
In-Reply-To: <20180507060322.66b121bd@kilabit.info>
> On Sun, 6 May 2018 22:03:10 +0200
> Martin Ågren <martin.agren@gmail.com> wrote:
> > On 6 May 2018 at 21:03, Shulhan <ms@kilabit.info> wrote:
> > > [alias]
> > > tree = --no-pager log --graph \
> > > -n 20 \
> > > [user]
> > > name = Shulhan
> > >
> > > (2) Run `git config -f git.config -l`
> > >
> > > The command print the following output,
> > >
> > > alias.tree=--no-pager log --graph -n 20 [user]
> > > alias.name=Shulhan
> >
> > Small mistake, big consequences. :-)
> >
> > This behavior looks correct to me, though. It seems very hard to me to
> > second-guess what the user meant. For example, what if that third line
> > contained a "="? Like:
> >
> > [alias]
> > huh = !dd \
> > bs=1024 ...
> >
> > Should Git guess that the backslash on the second line was a mistake?
> > Or maybe not, because alias.bs = "1024 ..." would be a useless alias?
>
> The context of multiline next value that I reported before was
> about section, not variable.
>
> >
> > I think such guessing would be theoretically possible, but especially
> > if Git guesses wrong, that could be very frustrating to fight against.
> >
>
> I'm not familiar with git config parser, obviously :), but checking
> the start of next multiline value that start with '[' maybe not
> impossible. Git should not guessed, but report error at the
> offending line: either user forgot to enclosed the variable with
> double quote or they missplace the backslash.
But it's not an error; as far as the config file syntax is concerned,
it's perfectly valid, even if it's not what you intended. Reporting it
as error would be just guessing.
prev parent reply other threads:[~2018-05-06 23:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 19:03 [bug] Multiline value should error if the next line is section Shulhan
2018-05-06 20:03 ` Martin Ågren
2018-05-06 21:09 ` brian m. carlson
2018-05-06 23:03 ` Shulhan
2018-05-06 23:25 ` SZEDER Gábor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180506232514.3065-1-szeder.dev@gmail.com \
--to=szeder.dev@gmail.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
--cc=ms@kilabit.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).