From: Antonio Ospite <ao2@ao2.it>
To: Brandon Williams <bmwill@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] doc: fix config API documentation about config_with_options
Date: Sat, 12 May 2018 00:17:05 +0200 [thread overview]
Message-ID: <20180512001705.1ce66754ce72d2b57c7e6d96@ao2.it> (raw)
In-Reply-To: <20180509171950.GB63423@google.com>
On Wed, 9 May 2018 10:19:50 -0700
Brandon Williams <bmwill@google.com> wrote:
> On 05/09, Antonio Ospite wrote:
> > In commit dc8441fdb ("config: don't implicitly use gitdir or commondir",
> > 2017-06-14) the function git_config_with_options was renamed to
> > config_with_options to better reflect the fact that it does not access
> > the git global config or the repo config by default.
> >
> > However Documentation/technical/api-config.txt still refers to the
> > previous name, fix that.
> >
> > While at it also update the documentation about the extra parameters,
> > because they too changed since the initial definition.
> >
> > Signed-off-by: Antonio Ospite <ao2@ao2.it>
> > ---
> >
> > Patch based on the maint branch.
>
> Thanks for updating the docs. Maybe one day we can migrate these docs
> to the source files themselves, making it easier to keep up to date.
> For now this is good :)
>
Should I resend the patch to gitster@pobox.com with your Acked-by?
Thanks,
Antonio
--
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
next prev parent reply other threads:[~2018-05-11 22:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 13:16 [PATCH] doc: fix config API documentation about config_with_options Antonio Ospite
2018-05-09 17:19 ` Brandon Williams
2018-05-11 22:17 ` Antonio Ospite [this message]
2018-05-14 18:22 ` Brandon Williams
2018-05-12 1:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180512001705.1ce66754ce72d2b57c7e6d96@ao2.it \
--to=ao2@ao2.it \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).