From: "Luis Marsano" <luis.marsano@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: <git@vger.kernel.org>, "Ted Zlatanov" <tzz@lifelogs.com>
Subject: Re: [PATCH 1/2] git-credential-netrc: adapt to test framework for git
Date: Mon, 14 May 2018 05:46:01 -0400 [thread overview]
Message-ID: <20180514054601.5805@lmm-notebook.localdomain> (raw)
In-Reply-To: Your message of Thu, 10 May 2018 18:43:19 +0900 <xmqq7eobkfrc.fsf@gitster-ct.c.googlers.com>
Junio C Hamano <gitster@pobox.com> wrote:
> Luis Marsano <luis.marsano@gmail.com> writes:
>
> > until this change, git-credential-netrc did not test in a repository
> > this change reuses the main test framework, which provides such tests
> > specific changes
>
> Sorry, but I cannot quite parse what the above is trying to say.
>
[⋮]
>
> Will queue, but may need to make the log message
> readable/understandable.
>
> Thanks.
Thank you, the rewrite https://public-inbox.org/git/20180512091728.4931-2-luis.marsano@gmail.com/ should be more intelligible.
I welcome further criticisms if any.
next prev parent reply other threads:[~2018-05-14 9:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 21:36 [PATCH 0/2] Configurable GnuPG command for git-credential-netrc Luis Marsano
2018-05-09 21:36 ` [PATCH 1/2] git-credential-netrc: adapt to test framework for git Luis Marsano
2018-05-10 9:43 ` Junio C Hamano
2018-05-14 9:46 ` Luis Marsano [this message]
2018-05-09 21:36 ` [PATCH 2/2] git-credential-netrc: accept gpg option Luis Marsano
2018-05-10 9:57 ` Junio C Hamano
2018-05-14 10:20 ` Luis Marsano
2018-05-12 9:17 ` [PATCH v2 0/2] Configurable GnuPG command for git-credential-netrc Luis Marsano
2018-05-12 9:17 ` [PATCH v2 1/2] git-credential-netrc: adapt to test framework for git Luis Marsano
2018-05-12 9:17 ` [PATCH v2 2/2] git-credential-netrc: accept gpg option Luis Marsano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514054601.5805@lmm-notebook.localdomain \
--to=luis.marsano@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).