From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 3F5751F406 for ; Mon, 14 May 2018 14:09:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753903AbeENOJD (ORCPT ); Mon, 14 May 2018 10:09:03 -0400 Received: from cloud.peff.net ([104.130.231.41]:39406 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753894AbeENOJD (ORCPT ); Mon, 14 May 2018 10:09:03 -0400 Received: (qmail 16184 invoked by uid 109); 14 May 2018 14:09:02 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Mon, 14 May 2018 14:09:02 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 29703 invoked by uid 111); 14 May 2018 14:09:08 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Mon, 14 May 2018 10:09:08 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Mon, 14 May 2018 10:09:01 -0400 Date: Mon, 14 May 2018 10:09:00 -0400 From: Jeff King To: Derrick Stolee Cc: git@vger.kernel.org, Derrick Stolee , Junio C Hamano Subject: Re: [PATCH 4/4] mark_parents_uninteresting(): avoid most allocation Message-ID: <20180514140900.GA10636@sigill.intra.peff.net> References: <20180511180029.GA11290@sigill.intra.peff.net> <20180511180314.GD12543@sigill.intra.peff.net> <8447da69-d28a-433c-f324-a6380b6ca991@gmail.com> <20180514130907.GB9219@sigill.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, May 14, 2018 at 09:25:46AM -0400, Derrick Stolee wrote: > > I think you'd want to go the other way: this is marking uninteresting > > commits, so you'd want origin/master..master, which would make those 70k > > commits uninteresting. > > Thanks for the tip. Running 'git rev-list origin/master..master' 100 times > gave the following times, on average (with ds/generation-numbers): > > PATCH 3/4: 0.19 s > PATCH 4/4: 0.16 s >     Rel %: -16% Nifty. I liked it as just a cleanup, but I'm happier still to find that it makes things faster (even if it's pretty small in absolute numbers). -Peff