From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: js/empty-config-section-fix, was Re: What's cooking in git.git (May 2018, #03; Wed, 23)
Date: Tue, 29 May 2018 12:49:12 -0400 [thread overview]
Message-ID: <20180529164912.GA13385@sigill.intra.peff.net> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1805281319530.82@tvgsbejvaqbjf.bet>
On Mon, May 28, 2018 at 01:20:41PM +0200, Johannes Schindelin wrote:
> On Mon, 28 May 2018, Junio C Hamano wrote:
>
> > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> >
> > > On Thu, 24 May 2018, Junio C Hamano wrote:
> > >
> > >> * js/empty-config-section-fix (2018-05-18) 1 commit
> > >> - config: a user-provided invalid section is not a BUG
> > >>
> > >> Error codepath fix.
> > >>
> > >> Will merge to 'next'.
> > >
> > > As a hotfix, maybe we can fast-track it to master?
> >
> > Hotfix is a proposed fix for an issue that is so important to be a
> > showstopper. This one must be fixed before the final release, but I
> > do not think it's not that urgent to force us to drop everything
> > else and merge it to master immediately.
>
> Well, in this case, a user might report a BUG when they simply have an
> invalid config.
>
> I do not care all that much, but Peff (who reported this) might.
I think it's fine to just fix it before release. Both the likelihood of
it happening and its severity are pretty low.
-Peff
prev parent reply other threads:[~2018-05-29 16:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 0:02 What's cooking in git.git (May 2018, #03; Wed, 23) Junio C Hamano
2018-05-24 6:39 ` Elijah Newren
2018-05-28 5:34 ` Junio C Hamano
2018-05-24 19:09 ` Stefan Beller
2018-05-24 19:42 ` Ævar Arnfjörð Bjarmason
2018-05-24 19:50 ` Luke Diamand
2018-05-25 12:31 ` js/empty-config-section-fix, was " Johannes Schindelin
2018-05-28 5:40 ` Junio C Hamano
2018-05-28 11:20 ` Johannes Schindelin
2018-05-29 16:49 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529164912.GA13385@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).